-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecating more networks #23695
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js
Did you find this useful? React with a 👍 or 👎 |
dbc9115
to
ee86abf
Compare
Builds ready [850fa2e]
Page Load Metrics (964 ± 525 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23695 +/- ##
===========================================
+ Coverage 67.54% 67.61% +0.07%
===========================================
Files 1245 1246 +1
Lines 48866 48885 +19
Branches 12744 12754 +10
===========================================
+ Hits 33005 33053 +48
+ Misses 15861 15832 -29 ☔ View full report in Codecov by Sentry. |
Builds ready [419d3ba]
Page Load Metrics (1135 ± 551 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
419d3ba
to
43c3db5
Compare
Builds ready [43c3db5]
Page Load Metrics (826 ± 482 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
46fbbbc
to
8792318
Compare
Builds ready [c39ecae]
Page Load Metrics (415 ± 361 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Why do we need to patch controller utils? Couldn't be update the package instead? |
a50c19c
Builds ready [4c91b58]
Page Load Metrics (552 ± 452 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [59155fd]
Page Load Metrics (866 ± 508 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit! Otherwise looks great!
Builds ready [03a1e14]
Page Load Metrics (660 ± 480 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Missing release label release-11.16.0 on PR. Adding release label release-11.16.0 on PR and removing other release labels(release-11.17.0), as PR was added to branch 11.16.0 when release was cut. |
Description
Deprecates Mumbai and linea goerli test networks.
Users should see a deprecation warning when switching to those networks.
Linea goerli is removed from the default network list.
Related issues
ticket: https://consensyssoftware.atlassian.net/browse/MMASSETS-183
patch for controller-utils: https://github.com/MetaMask/metamask-extension/pull/23727/files
Manual testing steps
Screenshots/Recordings
Before
Linea goerli appears in the list of default networks
After
In this video initially the user is on Linea goerli (i am on develop branch), the user makes a few transactions on linea goerli,
then i switch to this branch so the migration runs, and notice that the user has switeched to linea-sepolia.
Linea goerli is removed from the default networks tab.
When the user adds linea-goerli using chainlist, he sees the deprecation warning and his transactions.
deprecation1.mov
This short video shows the deprecation warning when we switch to Mumbai network
Screen.Recording.2024-03-26.at.16.12.46.mov
Pre-merge author checklist
Pre-merge reviewer checklist