Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache subject metadata for redirect #23999

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Apr 12, 2024

Description

Caches subject metadata on the permission redirect screen, fixing the problem where the dapp icon would disappear while redirecting. Also fixes the centering on this icon as well as multiple other icons in the app.

Open in GitHub Codespaces

Manual testing steps

  1. Connect to any dapp
  2. Notice the difference in the redirection screen

Screenshots/Recordings

Before

b4.mp4

After

after.mp4

@FrederikBolding FrederikBolding requested a review from a team as a code owner April 12, 2024 14:49
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 12, 2024
@FrederikBolding FrederikBolding requested review from a team as code owners April 12, 2024 14:53
@metamaskbot
Copy link
Collaborator

Builds ready [de8e776]
Page Load Metrics (680 ± 491 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6855914511053
domContentLoaded1189302010
load5326776801024491
domInteractive1189302010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 78 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (1098a10) to head (de8e776).

Files Patch % Lines
...connect/redirect/permissions-redirect.component.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23999      +/-   ##
===========================================
- Coverage    67.54%   67.54%   -0.01%     
===========================================
  Files         1245     1245              
  Lines        48866    48870       +4     
  Branches     12744    12745       +1     
===========================================
  Hits         33005    33005              
- Misses       15861    15865       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 12, 2024
@FrederikBolding FrederikBolding merged commit 07de882 into develop Apr 15, 2024
68 of 70 checks passed
@FrederikBolding FrederikBolding deleted the fb/cache-subject-metadata-for-redirect branch April 15, 2024 07:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 15, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants