-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cache subject metadata for redirect #23999
Merged
FrederikBolding
merged 3 commits into
develop
from
fb/cache-subject-metadata-for-redirect
Apr 15, 2024
Merged
fix: cache subject metadata for redirect #23999
FrederikBolding
merged 3 commits into
develop
from
fb/cache-subject-metadata-for-redirect
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [de8e776]
Page Load Metrics (680 ± 491 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23999 +/- ##
===========================================
- Coverage 67.54% 67.54% -0.01%
===========================================
Files 1245 1245
Lines 48866 48870 +4
Branches 12744 12745 +1
===========================================
Hits 33005 33005
- Misses 15861 15865 +4 ☔ View full report in Codecov by Sentry. |
gauthierpetetin
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Apr 12, 2024
darkwing
approved these changes
Apr 12, 2024
NidhiKJha
approved these changes
Apr 13, 2024
OGPoyraz
approved these changes
Apr 15, 2024
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Apr 15, 2024
metamaskbot
added
the
release-11.16.0
Issue or pull request that will be included in release 11.16.0
label
Apr 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-11.16.0
Issue or pull request that will be included in release 11.16.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caches subject metadata on the permission redirect screen, fixing the problem where the dapp icon would disappear while redirecting. Also fixes the centering on this icon as well as multiple other icons in the app.
Manual testing steps
Screenshots/Recordings
Before
b4.mp4
After
after.mp4