Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed wallet view bugs for connections and permissions screen #24023

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Apr 15, 2024

This PR is to fix the UI bugs in the wallet, permissions and connections screen to keep it in sync with the Updated designs

Description

Following changes are updated:

  1. Description of the product tour for global menu [Note: This product tour will be removed]
  2. Remove Connected dApp shown on Account List Item
  3. Remove Connect account action in Select Account Modal

Related issues

Fixes: #23858

Manual testing steps

This PR solves Part of the linked issue, rest of them are already resolved via different other PRs, Linking them in the list:

  1. Description of the product tour for global menu - Modified in this PR
  2. Connected sites and All Permissions in Global menu - 23789
  3. Remove Connected dApp shown on Account List Item - Modified in this PR
  4. Connected Account Toast should only be displayed on Wallet screen - 23733
  5. Remove Connect account action in Select Account Modal - Modified in this PR
  6. Network switching within Extension - This isssue doesn't exist anymore.
  7. Button in Network switch Modal - Was related to Design System, fixed.

Screenshots/Recordings

Before

Please refer to the issue

After

  1. This Product tour will be removed in a separate PR
  2. No dapp logo on account list item even when it's connected
    Screenshot 2024-04-16 at 3 02 46 PM
  3. No connect button in account list item menu

Screenshot 2024-04-16 at 3 03 23 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner April 15, 2024 06:59
@NidhiKJha NidhiKJha added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.52%. Comparing base (9c78339) to head (27bb99a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24023      +/-   ##
===========================================
- Coverage    67.52%   67.52%   -0.01%     
===========================================
  Files         1244     1244              
  Lines        48807    48798       -9     
  Branches     12747    12742       -5     
===========================================
- Hits         32955    32946       -9     
  Misses       15852    15852              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [27bb99a]
Page Load Metrics (1124 ± 609 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint602181264321
domContentLoaded106530168
load50294611241269609
domInteractive106530168
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -403 Bytes (-0.01%)
  • common: -2 Bytes (-0.00%)

@NidhiKJha NidhiKJha merged commit c1b2cbe into develop Apr 16, 2024
70 of 71 checks passed
@NidhiKJha NidhiKJha deleted the fix-23858 branch April 16, 2024 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wallet View DQA
4 participants