-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed wallet view bugs for connections and permissions screen #24023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
added
team-wallet-ux
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
labels
Apr 15, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24023 +/- ##
===========================================
- Coverage 67.52% 67.52% -0.01%
===========================================
Files 1244 1244
Lines 48807 48798 -9
Branches 12747 12742 -5
===========================================
- Hits 32955 32946 -9
Misses 15852 15852 ☔ View full report in Codecov by Sentry. |
Builds ready [27bb99a]
Page Load Metrics (1124 ± 609 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
darkwing
approved these changes
Apr 15, 2024
jonybur
approved these changes
Apr 16, 2024
metamaskbot
added
the
release-11.16.0
Issue or pull request that will be included in release 11.16.0
label
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-11.16.0
Issue or pull request that will be included in release 11.16.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the UI bugs in the wallet, permissions and connections screen to keep it in sync with the Updated designs
Description
Following changes are updated:
Related issues
Fixes: #23858
Manual testing steps
This PR solves Part of the linked issue, rest of them are already resolved via different other PRs, Linking them in the list:
Screenshots/Recordings
Before
Please refer to the issue
After
Pre-merge author checklist
Pre-merge reviewer checklist