Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump-metamask-controllers-util-to-9.1.0 #24107

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Apr 18, 2024

Description

Bumps controller-utils to latest controller-utils v9.1.0

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2278
Relates to: https://github.com/MetaMask/core/pull/4153/files

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner April 18, 2024 12:31
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the team-confirmations-secure-ux-PR PRs from the confirmations team label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (1cf139e) to head (4209fae).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24107   +/-   ##
========================================
  Coverage    67.60%   67.60%           
========================================
  Files         1252     1252           
  Lines        49019    49019           
  Branches     12783    12783           
========================================
  Hits         33139    33139           
  Misses       15880    15880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [a3ac0e7]
Page Load Metrics (1973 ± 668 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint814141928842
domContentLoaded11123373115
load67395119731391668
domInteractive11123373115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand digiwand merged commit 02a3892 into develop Apr 18, 2024
67 of 69 checks passed
@digiwand digiwand deleted the chore-bump-controller-utils-to-latest-9.1.0 branch April 18, 2024 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4209fae]
Page Load Metrics (1311 ± 660 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint613791539043
domContentLoaded96729178
load48317113111375660
domInteractive96729178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants