Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v11.14.5 #24342

Merged
merged 5 commits into from
May 2, 2024
Merged

Version v11.14.5 #24342

merged 5 commits into from
May 2, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 2, 2024

Testing instructions for 8c9ed8f:

  1. Visit https://www.fxhash.xyz/generative/slug/g-l-y-p-h
  2. Try minting the nft
  3. Simulation should work and show the nft in the "You receive" section.

Testing instructions for 2d9f5f7:

  1. Setup metamask so that it will send metrics events. This requires building with the SEGMENT_WRITE_KEY set, and setting "Participate in MetaMetrics" to true.
  2. Open the background console and the network tab
  3. Go through the send flow and confirm a transaction
  4. Once it is no longer pending and is confirmed, you should see a network request to segment, with "Transaction Finalized" in the payload

Testing instructions for 949e733:

  1. Trigger any number of transactions
  2. Do not see "Edit" in header
  3. Open MetaMask, manually start a send, see the "Edit" button

Copy link
Contributor

github-actions bot commented May 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 2, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [2079594]
Page Load Metrics (712 ± 469 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64147992210
domContentLoaded95820115
load512521712977469
domInteractive95820115

@metamaskbot metamaskbot added the release-11.14.5 Issue or pull request that will be included in release 11.14.5 label May 2, 2024
cherry-pick fix NFT mint simulations by updating transaction-controller
(#24306) to v11.14.5

NOTE: This commit is not a cherry-pick of an existing commit. To ensure
peer dependencies were met, yarn add
@metamask/transaction-controller@^28.1.1 was run against v11.14.5 and
the results were committed.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Copy link

socket-security bot commented May 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@28.1.1 network Transitive: filesystem +8 3.88 MB metamaskbot

🚮 Removed packages: npm/@metamask/transaction-controller@27.0.1

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [8c9ed8f]
Page Load Metrics (1755 ± 899 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint603021255928
domContentLoaded10115272211
load49458417551873899
domInteractive10115272211

danjm and others added 2 commits May 2, 2024 15:43
…transactions (#24334) (#24354)

Cherry picks 4a1853c (#24322) to v11.14.5

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
@danjm
Copy link
Contributor Author

danjm commented May 2, 2024

@SocketSecurity ignore-all

@metamaskbot
Copy link
Collaborator

Builds ready [646ea2e]
Page Load Metrics (605 ± 611 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7015396189
domContentLoaded14322152
load5441946051273611
domInteractive14312152

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.14.5 Issue or pull request that will be included in release 11.14.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants