fix: Notifications platform links

[matteoscurati]

Description

This PR introduces the logic to handle links within notifications to support the different platforms on which we can use the extension.

Related issues

Fixes:

Manual testing steps

1. Open the notifications list page
2. Click on a product announcement
3. Check the link in the detail page

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Prithpal-Sooriya]

Double check this getPlatform code.
This calls window.navigator, and the window does not exist on service workers.
We might want to replace this with global.navigator or self.navigator

@danjm is this function getPlatform used in other controllers? We are not seeing any regressions or errors using this? If it works, then feel free to keep using it @matteoscurati .

[matteoscurati]

@Prithpal-Sooriya everything seems to be working correctly. I tried generating the links by also printing the different steps and everything seems to work

[danjm]

Because of this: https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/init-globals.js#L17

window, in our app/ code under mv3, refers to the ServiceWorkerGlobalScope and not an actual window. The ServiceWorkerGlobalScope has some, but not all, of the apis an actual window has. navigator is one of the APIs it does have, so this should be fine

The base branch was changed.

[metamaskbot]

Builds ready [5ac245e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1316 ± 596 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	149	112	20	10
		domContentLoaded	9	52	17	11	5
		load	68	2946	1316	1241	596
		domInteractive	9	52	17	11	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 22 Bytes (0.00%)
• ui: 1.9 KiB (0.03%)
• common: 1 Bytes (0.00%)

[danjm]

I don't think ?? defaultNetwork?.rpcUrl should be here, as rpcUrl should never be a block explorer url

[matteoscurati]

@danjm you’re right. This is the type:

export type NetworkConfiguration = {
    rpcUrl: string;
    chainId: Hex;
    ticker: string;
    nickname?: string;
    rpcPrefs?: {
        blockExplorerUrl: string;
    };
};

I removed defaultNetwork?.rpcUrl

[danjm]

One more comment from me

[danjm]

lgtm

[Prithpal-Sooriya]

Ok LGTM. We will get another Notification dev to review. This was previously approved by Dan too.

[metamaskbot]

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0.