Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update swaps base url #24767

Closed
wants to merge 12 commits into from
Closed

chore: update swaps base url #24767

wants to merge 12 commits into from

Conversation

nikoferro
Copy link
Member

@nikoferro nikoferro commented May 24, 2024

Description

This PR only updates the old swaps API url, to the new one. More specifically replaching swap.metaswap.codefi.network with swap.api.cx.metamask.io

Open in GitHub Codespaces

Related issues

Fixes: --

Manual testing steps

  1. Go to any network where swaps is enabled
  2. Try to fetch a quote

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@nikoferro nikoferro marked this pull request as ready for review May 24, 2024 09:57
@nikoferro nikoferro requested review from a team as code owners May 24, 2024 09:57
infiniteflower
infiniteflower previously approved these changes May 24, 2024
callumelvidge
callumelvidge previously approved these changes Jun 3, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.62%. Comparing base (0fd5f5e) to head (595aa14).

Current head 595aa14 differs from pull request most recent head c765463

Please upload reports for the commit c765463 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24767      +/-   ##
===========================================
- Coverage    65.63%   65.62%   -0.01%     
===========================================
  Files         1375     1373       -2     
  Lines        54553    54532      -21     
  Branches     14294    14285       -9     
===========================================
- Hits         35803    35783      -20     
+ Misses       18750    18749       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [595aa14]
Page Load Metrics (56 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint68199932713
domContentLoaded9331252
load4110556178
domInteractive9331252
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@callumelvidge
Copy link
Member

Is SWAPS_API_V2_BASE_URL an appropriate name for this URL? It's not for Swap API v2, it's just an updated URL.

@nikoferro
Copy link
Member Author

Is SWAPS_API_V2_BASE_URL an appropriate name for this URL? It's not for Swap API v2, it's just an updated URL.

thats actually a good point, that i didnt even think of, and now i read the var name and it doesnt make any sense... will remove the V2 part of the name

@nikoferro
Copy link
Member Author

closing this as duplicate: #24698

@nikoferro nikoferro closed this Jun 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants