-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: password reset #25847
fix: password reset #25847
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
465a197
to
9739a22
Compare
@metamaskbot update-policies |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ |
Policies updated |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25847 +/- ##
========================================
Coverage 69.76% 69.76%
========================================
Files 1398 1398
Lines 49171 49171
Branches 13574 13574
========================================
Hits 34303 34303
Misses 14868 14868 ☔ View full report in Codecov by Sentry. |
Builds ready [eb7514b]
Page Load Metrics (152 ± 179 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@metamaskbot update-policies |
No policy changes |
eb7514b
to
9d1e2cc
Compare
@metamaskbot update-policies |
Policies updated |
5b81ec0
to
047402c
Compare
|
Builds ready [047402c]
Page Load Metrics (164 ± 157 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Unfortunately, I didn't notice that this bump breaks a peer dependency rule for |
Description
Related issues
Fixes: #25696
Manual testing steps
Screenshots/Recordings
Before
Reset.wallet.Chrome.mov
After
Screen.Recording.2024-07-16.at.5.55.05.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist