test: chainid, switch custom net, batch tx diff, snaps #27725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
seaona
commented
Oct 9, 2024
| await driver.clickElement({ | ||
| text: 'Connect', | ||
| tag: 'button', | ||
| }); | ||
|
|
||
| await driver.waitForSelector({ text: 'Connect' }); |
There was a problem hiding this comment.
not needed as clicking the element already implies the button is there and clickable
seaona
commented
Oct 9, 2024
| await driver.waitForSelector({ text: 'OK' }); | ||
|
|
||
| await driver.clickElement({ | ||
| await driver.clickElementAndWaitForWindowToClose({ |
There was a problem hiding this comment.
this mitigates race conditions: we should not proceed to the next step until the dialog is closed
seaona
commented
Oct 9, 2024
| await switchToNotificationWindow(driver); | ||
| await driver.clickElement({ | ||
| await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog); | ||
| await driver.clickElementAndWaitForWindowToClose({ |
There was a problem hiding this comment.
same, wait for the dialog to close before proceeding
seaona
commented
Oct 9, 2024
| await driver.clickElement({ | ||
| text: 'Connect', | ||
| tag: 'button', | ||
| }); | ||
|
|
||
| await driver.waitForSelector({ text: 'Confirm' }); |
seaona
commented
Oct 9, 2024
| await driver.waitForSelector({ text: 'OK' }); | ||
|
|
||
| await driver.clickElement({ | ||
| await driver.clickElementAndWaitForWindowToClose({ |
There was a problem hiding this comment.
wait for the dialog to close before proceeding
seaona
commented
Oct 9, 2024
| await switchToNotificationWindow(driver, 2); | ||
| await driver.clickElement({ | ||
| await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog); | ||
| await driver.clickElementAndWaitForWindowToClose({ |
There was a problem hiding this comment.
wait for the dialog to close before proceeding
seaona
commented
Oct 9, 2024
|
|
||
| await driver.delay(regularDelayMs); |
seaona
commented
Oct 9, 2024
| await switchToNotificationWindow(driver); | ||
|
|
||
| await driver.clickElement({ | ||
| await driver.clickElementAndWaitForWindowToClose({ |
There was a problem hiding this comment.
wait for the dialog to close before proceeding
seaona
commented
Oct 9, 2024
| @@ -82,14 +77,11 @@ describe('Request Queuing for Multiple Dapps and Txs on different networks', fun | |||
| await openDapp(driver, undefined, DAPP_ONE_URL); | |||
|
|
|||
| // Connect to dapp 2 | |||
| await driver.findClickableElement({ text: 'Connect', tag: 'button' }); | |||
seaona
commented
Oct 9, 2024
| await driver.findClickableElement({ text: 'Connect', tag: 'button' }); | ||
| await driver.clickElement('#connectButton'); | ||
|
|
||
| await driver.delay(regularDelayMs); |
seaona
commented
Oct 9, 2024
|
|
||
| await driver.findElement( | ||
| await driver.waitForSelector( |
seaona
commented
Oct 9, 2024
| By.xpath("//div[normalize-space(.)='1 of 2']"), | ||
| ); | ||
|
|
||
| // Reject All Transactions | ||
| await driver.clickElement('.page-container__footer-secondary a'); | ||
|
|
||
| await driver.clickElement({ text: 'Reject all', tag: 'button' }); // TODO: Do we want to confirm here? | ||
| // TODO: Do we want to confirm here? | ||
| await driver.clickElementAndWaitForWindowToClose({ |
There was a problem hiding this comment.
wait for the dialog to close before proceeding
seaona
commented
Oct 9, 2024
|
|
||
| await driver.findElement( | ||
| await driver.waitForSelector( |
seaona
commented
Oct 9, 2024
|
|
||
| await driver.delay(regularDelayMs); |
seaona
commented
Oct 9, 2024
| await driver.waitForSelector({ | ||
| css: '[id="chainId"]', | ||
| text: '0x539', | ||
| }); |
There was a problem hiding this comment.
ensure the test dapp has the new chain id too
seaona
commented
Oct 9, 2024
| await driver.waitForSelector({ | ||
| css: '[id="chainId"]', | ||
| text: '0x1', | ||
| }); |
There was a problem hiding this comment.
ensure the test dapp has the new chain id too
|
Builds ready [d4d1ffe]
Page Load Metrics (1929 ± 103 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist