Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #4639: display values of EIP712 typed boolean fields in the signing prompt #4640

Merged
merged 4 commits into from
Jun 29, 2018

Conversation

weijiekoh
Copy link
Contributor

This PR fixes issue #4639.

@danjm
Copy link
Contributor

danjm commented Jun 27, 2018

@weijiekoh PR looks good. There is a lint error. Can you run npm run lint and fix the error? (You'll see a bunch of lint warnings, but we are only concerned about the error. I think you just need to use single quotes instead of double quotes.

@weijiekoh
Copy link
Contributor Author

Thanks. Fixed that lint error with commit f17d99f.

@danjm danjm merged commit 22debbf into MetaMask:develop Jun 29, 2018
@om26er
Copy link

om26er commented Jul 30, 2020

Curious if this regressed in latest versions again ? The 'consent' field is supposed to be a boolean, however the dialog doesn't really show that.
metamask-regression

@Gudahtt
Copy link
Member

Gudahtt commented Aug 6, 2020

Thanks for the report @om26er ! I've re-opened the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants