Auto-detect tokens #3034 #4683

estebanmino · 2018-06-27T21:56:17Z

Auto-detect tokens feature

TrejGun · 2018-07-05T09:22:38Z

app/scripts/controllers/detect-tokens.js

+   *
+   * @param {Object} [config] - Options to configure controller
+   */
+  constructor ({ interval = DEFAULT_INTERVAL, preferences, network } = {}) {


contracts is lost

TrejGun · 2018-07-05T09:37:04Z

app/scripts/controllers/detect-tokens.js

+    const address = this._preferences.store.getState().selectedAddress
+    const response = await fetch(`https://api.etherscan.io/api?module=account&action=tokenbalance&contractaddress=${contractAddress}&address=${address}&tag=latest&apikey=NCKS6GTY41KPHWRJB62ES1MDNRBIT174PV`)
+    const parsedResponse = await response.json()
+    if (parsedResponse.result !== '0') {


the theory is good, if result > 0 you have tokens
but for real case

{"status":"1","message":"OK","result":"8121799999999999999558"}

i have 8121 tokens, because contract code says
uint8 public decimals = 18;
so let say i have

{"status":"1","message":"OK","result":"1000"}

1000 > 0 but it still means nothing because 1000 * 1e-18 = 1e-15 = 0

1e-15 = 0 is a false statement, we can disregard this comment.

danfinlay

Just some cleanups that'll make it a bit stronger, thanks so much for doing this!

danfinlay · 2018-07-05T18:51:33Z

app/scripts/controllers/detect-tokens.js

+    for (const address in this.contracts) {
+        const contract = this.contracts[address]
+        if (contract.erc20 && !(address in this.tokens)) {
+          detectedTokenAddress = await this.fetchContractAccountBalance(address) 


Should probably be named detectedTokenBalance.

danfinlay · 2018-07-05T18:52:08Z

app/scripts/controllers/detect-tokens.js

+          }
+        }
+        // etherscan restriction, 5 request/second, lazy scan
+        setTimeout(() => {}, 200)


This is non-blocking. you probably want to do something like:
await new Promise((res, rej) => { setTimeout(res, 200) })

Really we want to reset the interval here, so we want to do something more like:

await new Promise((res, rej) => { setTimeout(res, 200) }) this.exploreNewTokens()

danfinlay · 2018-07-05T18:53:58Z

app/scripts/controllers/detect-tokens.js

+   */
+  async fetchContractAccountBalance (contractAddress) {
+    const address = this._preferences.store.getState().selectedAddress
+    const response = await fetch(`https://api.etherscan.io/api?module=account&action=tokenbalance&contractaddress=${contractAddress}&address=${address}&tag=latest&apikey=NCKS6GTY41KPHWRJB62ES1MDNRBIT174PV`)


Let's update this to a MetaMask-org API key: ZPN1UTJR48QKJT6GZTJEZYHBMKTK42EPWR.

danfinlay · 2018-07-05T18:56:09Z

app/scripts/controllers/detect-tokens.js

+    const address = this._preferences.store.getState().selectedAddress
+    const response = await fetch(`https://api.etherscan.io/api?module=account&action=tokenbalance&contractaddress=${contractAddress}&address=${address}&tag=latest&apikey=NCKS6GTY41KPHWRJB62ES1MDNRBIT174PV`)
+    const parsedResponse = await response.json()
+    if (parsedResponse.result !== '0') {


1e-15 = 0 is a false statement, we can disregard this comment.

danfinlay · 2018-07-05T19:03:03Z

test/unit/app/controllers/detect-tokens-test.js

+const ObservableStore = require('obs-store')
+
+describe('DetectTokensController', () => {
+  it('should poll on correct interval', async () => {


Could use a test to verify that a second call is fired after a second interval.

danfinlay · 2018-07-05T19:05:00Z

test/unit/app/controllers/detect-tokens-test.js

+            'decimals': 18,
+        },
+      }
+    controller.fetchContractAccountBalance = address => address


Might be worth using sinon.stub here, so it can be automatically cleaned up after the test.

danfinlay · 2018-07-05T19:06:23Z

test/unit/app/controllers/detect-tokens-test.js

+            'decimals': 18,
+        },
+    }
+    controller.fetchContractAccountBalance = address => address


This method is named a little strange, for returning an address.

danfinlay · 2018-07-05T19:07:30Z

test/unit/app/controllers/detect-tokens-test.js

+            'decimals': 18,
+        },
+    }
+    controller.fetchContractAccountBalance = address => address


Here if this was a sinon.stub, we could assert that it's only been called once.

Sinon example:

const tokenDetectorMock = sinon.mock(controller) tokenDetectorMock.expects('fetchContractAccountBalance').once() await controller.exploreNewTokens() mock.verify()

metamaskbot · 2018-07-13T01:06:25Z

Builds ready [2fffe09]: mascara, chrome, firefox, edge, opera

danfinlay · 2018-07-18T23:41:02Z

app/scripts/controllers/detect-tokens.js

+   * For each token in eth-contract-metada, find check selectedAddress balance.
+   *
+   */
+  async exploreNewTokens () {


I just tried it out. Every three minutes may be fine for a background poll, but if we really want this feature, we should make it responsive.

I think we should also trigger this function from the metamask-controller when:

submitPassword is successfully called.

When a new account is selected (It will be something like `this.preferencesController.store.subscribe((state) => /* check for new value here... we should discuss the best way to do this... makes me wish we were using Ember Object... */

It totally makes sense.
Actually in line 80 of detect-tokens.js there is a selectedAddress update each time that the address is changed that could be used to trigger this function or also to restart the polling period, what do you think about that?

That would be perfect, thank you!

Ok, I did it in a way that each time that the address is updated or there is a password submitted this function is going to be triggered and the polling is going to be initialized again. All from the detect-tokens controller to avoid dependency between those controllers.

Also rather than using the keyringController as a way to detect a submitPasword event I used the same method already implemented to detect when the extension is active and therefore the user logged in.

needs change on this last item

metamaskbot · 2018-07-20T00:03:06Z

Builds ready [009b1ce]: mascara, chrome, firefox, edge, opera

danfinlay

Looks great! Just add a changelog entry then feel free to merge!

rekmarks

Approving after Changelog commit invalidated Dan's review

metamaskbot · 2018-07-20T16:31:45Z

Builds ready [e73bdd2]: mascara, chrome, firefox, edge, opera

detect tokens polling

bfac9c2

estebanmino mentioned this pull request Jun 27, 2018

Auto-detect tokens on the add token screen #3034

Closed

estebanmino added 5 commits June 27, 2018 19:54

network store to detect token

0e863d5

tests for spec

6284e66

passtest-lint

03fd435

Merge branch 'develop' into detectTokenFeature

0494b2f

fix lint

63b9c87

estebanmino force-pushed the detectTokenFeature branch from b0af372 to 63b9c87 Compare July 3, 2018 19:29

TrejGun reviewed Jul 5, 2018

View reviewed changes

danfinlay requested changes Jul 5, 2018

View reviewed changes

estebanmino added 2 commits July 11, 2018 15:59

improve tests

910713c

detect tokens through infura

2fffe09

danfinlay reviewed Jul 18, 2018

View reviewed changes

estebanmino added 2 commits July 19, 2018 15:56

detect tokens when submit password and new account selected

3b97d81

keyring unlocked detect and unit tests

009b1ce

danfinlay previously approved these changes Jul 20, 2018

View reviewed changes

add changelog

e6ca794

estebanmino dismissed danfinlay’s stale review via e6ca794 July 20, 2018 16:14

Merge branch 'develop' into detectTokenFeature

e73bdd2

bdresser added the needs review label Jul 20, 2018

rekmarks approved these changes Jul 20, 2018

View reviewed changes

estebanmino merged commit cb045fd into develop Jul 20, 2018

estebanmino deleted the detectTokenFeature branch July 20, 2018 16:36

estebanmino mentioned this pull request Jul 20, 2018

Auto detect tokens occasionally in background. #2560

Closed

bdresser removed the needs review label Jul 23, 2018

bdresser mentioned this pull request Jul 23, 2018

Add tokens on a per account basis #3521

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-detect tokens #3034 #4683

Auto-detect tokens #3034 #4683

estebanmino commented Jun 27, 2018 •

edited

Loading

TrejGun Jul 5, 2018

TrejGun Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay left a comment

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

danfinlay Jul 5, 2018

metamaskbot commented Jul 13, 2018

danfinlay Jul 18, 2018

estebanmino Jul 19, 2018 •

edited

Loading

danfinlay Jul 19, 2018

estebanmino Jul 19, 2018

estebanmino Jul 19, 2018

estebanmino Jul 19, 2018

metamaskbot commented Jul 20, 2018

danfinlay left a comment

rekmarks left a comment

metamaskbot commented Jul 20, 2018

Auto-detect tokens #3034 #4683

Auto-detect tokens #3034 #4683

Conversation

estebanmino commented Jun 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danfinlay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Jul 13, 2018

Choose a reason for hiding this comment

estebanmino Jul 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Jul 20, 2018

danfinlay left a comment

Choose a reason for hiding this comment

rekmarks left a comment

Choose a reason for hiding this comment

metamaskbot commented Jul 20, 2018

estebanmino commented Jun 27, 2018 •

edited

Loading

estebanmino Jul 19, 2018 •

edited

Loading