Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware wallet fixes #5112

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Hardware wallet fixes #5112

merged 3 commits into from
Aug 21, 2018

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Aug 21, 2018 •
edited
Loading

  • Fix account removal
  • Change hardware wallet account label formatting (from TREZOR 1 to Trezor 1) to keep it consistent with the rest of the labels (we use Account 1 not ACCOUNT 1)

danfinlay
danfinlay approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@brunobar79
Copy link
Contributor Author

@danfinlay merging this in. CI errors are due to e2e flakiness

@brunobar79 brunobar79 merged commit 282820c into develop Aug 21, 2018
@danfinlay danfinlay deleted the hardware-wallet-fixes branch August 21, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfinlay danfinlay danfinlay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobar79 @danfinlay