4byte fallback #6551
4byte fallback #6551
Conversation
|
Just rebased onto latest develop |
|
Even with caching, this will send a lot of traffic to 4byte - @danfinlay can you check with the maintainer? Chatted with Infura and they are not keen to host a version of the API simply for bandwidth reasons |
|
Rebased onto developer |
|
* Remove async call from getTransactionActionKey() * Stop blocking confirm screen rendering on method data loading, and base screen route on transactionCategory * Remove use of withMethodData, fix use of knownMethodData, in relation to transaction-list-item.component * Load data contract method data progressively, making it non-blocking; requires simplifying conf-tx-base lifecycle logic. * Allow editing of gas price while loading on the confirm screen. * Fix transactionAction component and its unit tests. * Fix confirm transaction components for cases of route transitions within metamask. * Only call toString on id if truthy in getNavigateTxData()
|
Rebased onto develop |
|
From @danjm above, emphasis mine:[1]
Version 6.4.06.4.0 was the first version we shipped the 4byte fallback in. It made two lookup requests for each transaction in the transaction list and two lookup requests on the confirm screen. A network waterfall for 4 txs in the list:
You can notice that the two requests are dispatched at the same time (i.e., they're not staggered). It's also worth re-affirming that the old implementation handled failures for both requests—both requests failing individually and requests failing together:
With this PRThis PR adjusts how we dispatch the requests to reduce the requests made to 4byte. We now no longer make two requests per tx in the tx list. In fact, we now need no requests to render the tx list and make only two requests for each tx confirmation. |
There was a problem hiding this comment.
I feel confident that this makes significantly fewer requests than the previous implementation
@chikeichan @danjm can one of y'all give this a ✅
This higher-order-component has been unused since #6551
This higher-order-component has been unused since #6551
This PR re-introduces the 4byte fallback for
getMethodData, originally introduced in #6435.We'll want to improve how this behaves before landing it on
developagain, namely:knownMethodData, eliminate network requests for already known data (Fix use ofknownMethodData, elimate network requests for already known data #6530)Note: this feature branch will see the above changes made before it is marked as ready for review.This PR is ready for review.