Ensures that transactions cannot be confirmed if gas limit is below 21000 #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
suggested changes
May 17, 2019
| @@ -30,6 +30,7 @@ export default class AdvancedTabContent extends Component { | |||
| super(props) | |||
|
|
|||
| this.debouncedGasLimitReset = debounce((dVal) => { | |||
| console.log('------------123123123123123123----------------') | |||
There was a problem hiding this comment.
@whymarrh this is fixed
danjm
force-pushed
the
ensure-sufficient-gas-limit
branch
from
3a0b768
to
b982e71
Compare
danjm
force-pushed
the
ensure-sufficient-gas-limit
branch
from
b982e71
to
6e751b6
Compare
whymarrh
approved these changes
May 23, 2019
Merged
|
We cannot send coins from desktop extension on our chain, because we have lower gas fee than Ethereum. That should be fixed.. |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This was referenced Apr 10, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6373.
Ensures that transactions cannot be confirmed if gas limit is below 21000.