Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete to custom rpc form (rebased and e2e tests updated) #6718

Merged
merged 6 commits into from
Jun 17, 2019
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jun 17, 2019

This PR is the same as #6650, except that it has been rebased on develop and the e2e tests have been updated.

This closes #6650.

@danjm danjm requested a review from whymarrh as a code owner June 17, 2019 11:09
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chikeichan & @danjm!

@whymarrh whymarrh merged commit 18179fd into develop Jun 17, 2019
@whymarrh whymarrh deleted the delrpc branch June 17, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants