Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not transate on seed phrases #7260

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Oct 7, 2019

Fixes #7246
Fixes #7164
Add noTranslate class name on places where we show seed phrases.

@whymarrh
Copy link
Contributor

whymarrh commented Oct 7, 2019

I couldn't quite find a 2nd source for this classname, one that documented that it is indeed the classname used by the browser—can you confirm that this does prevent translation?

@tmashuang
Copy link
Contributor Author

tmashuang commented Oct 7, 2019

I've confirmed in a development environment. Can post a screencap if need be.

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tmashuang!

@metamaskbot
Copy link
Collaborator

Builds ready [aa95e5a]

@tmashuang tmashuang merged commit d7a4dfe into develop Oct 7, 2019
@tmashuang tmashuang deleted the notranslate-seed-phrases branch October 7, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants