Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct AppStateController with the persisted initial state #7581

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Construct AppStateController with the persisted initial state #7581

merged 1 commit into from
Nov 26, 2019

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Nov 26, 2019 •
edited
Loading

This PR updates the AppStateController to include the initState from the persisted state.

Gudahtt
Gudahtt approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Looks like the app state controller constructor already handles this appropriately.

@tmashuang tmashuang merged commit cd9ef4c into MetaMask:develop Nov 26, 2019
@whymarrh whymarrh deleted the fix-app-state-controller branch November 26, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@tmashuang tmashuang tmashuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whymarrh @Gudahtt @tmashuang