Do not check popupIsOpen on Vivaldi #9271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykLucka
force-pushed
the
do-not-check-poupisopen-on-vivaldi
branch
from
6e4c28b
to
0fa6e32
Compare
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
rekmarks
approved these changes
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vivaldi is not triggering disconnect() function on port when closing the popup/notification. It is first thing being triggered after manually opening popup again. This prevents popup from being reopened (since extension thinks popup is still open).
This PR adds an exception for Vivaldi browser not to check this condition, it can trigger multiple same notifications, but it's better than no notification.
Addresses the issues brought up in #9194