Fix ENS resolution of .eth
URLs with query strings
#9674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our ENS resolver for the browser address bar was incorrectly resolving addresses that included query strings. We were concatenating the
path
property with thesearch
property, despite the fact that thepath
property already containssearch
. As a result,search
was duplicated in the resolved addresses.For example, if an IPFS content ID was found for this address, the resolved address for
metamask.eth/?foo=bar
would have the path/?foo=bar?foo=bar
The original intent was likely to use
pathname
in place ofpath
. The resolver has been updated to usepathname
, and the query string now appears only once in the resolved address.