Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong amount out for onramp analytics #4468

Merged
merged 33 commits into from
Jun 13, 2022
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jun 7, 2022

> This PR is using base release/5.2.0. When that branch is merged to main, this should be updated to point to main as base.

This PR fixes a wrong variable being passed to analytics.

metamaskbot and others added 30 commits May 16, 2022 18:44
Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
* fix subtitle mapping

* delete

* fix pt

* put setTimeout back

Co-authored-by: Curtis David <Curtis.David7@gmail.com>
…#4360)

Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
* Refactor Transaction into Order for fiat orders

* Fix uppercase
@rickycodes rickycodes self-requested a review June 7, 2022 19:11
Base automatically changed from release/5.2.0 to main June 7, 2022 23:00
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei marked this pull request as ready for review June 8, 2022 13:56
@wachunei wachunei requested a review from a team as a code owner June 8, 2022 13:56
@wachunei wachunei merged commit 312e94e into main Jun 13, 2022
@wachunei wachunei deleted the fix/onramp-amount-analytics branch June 13, 2022 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2022
@mobularay mobularay added the release-5.3.0 All PRs that will be included in 5.3.0 release label Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.3.0 All PRs that will be included in 5.3.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants