Add minimum required params to orders #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
* fix subtitle mapping * delete * fix pt * put setTimeout back Co-authored-by: Curtis David <Curtis.David7@gmail.com>
…#4360) Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
* Refactor Transaction into Order for fiat orders * Fix uppercase
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
in e14871c @rickycodes I added the id because backend sometimes is not responding with the same id parameter it was requested with (it is a bug) |
rickycodes
approved these changes
Jun 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
> This PR is using baserelease/5.2.0. When that branch is merged tomain, this should be updated to point tomainas base.This PR makes sure the orders added to the state have the minimum required parameters to keep track of them