Skip to content

Commit

Permalink
fix: you have to press the login button twice (#6633) (#6663)
Browse files Browse the repository at this point in the history
<!--
Thanks for your contribution!

Please ensure that any applicable requirements below are satisfied
before submitting this pull request. This will help ensure a quick and
efficient review cycle.
-->

**Description**

When a user wants to login into the wallet they need to press the login
button twice. The issue comes from the way that the Scrollview component
is behaving when input is active.

**Screenshots/Recordings**

_If applicable, add screenshots and/or recordings to visualize the
before and after of your change_

**Issue**
Fix: #6633 

**Checklist**

* [x] There is a related GitHub issue
* [ ] Tests are included if applicable
* [ ] Any added code is fully documented

---------

Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: Frank von Hoven <141057783+frankvonhoven@users.noreply.github.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
  • Loading branch information
5 people authored Jan 25, 2024
1 parent e45d196 commit aea73a4
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion app/components/Views/Login/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import PropTypes from 'prop-types';
import {
Alert,
ActivityIndicator,
Keyboard,
View,
SafeAreaView,
StyleSheet,
Expand Down Expand Up @@ -371,6 +372,8 @@ class Login extends PureComponent {
this.props.selectedAddress,
);

Keyboard.dismiss();

// Get onboarding wizard state
const onboardingWizard = await DefaultPreference.get(ONBOARDING_WIZARD);
if (onboardingWizard) {
Expand Down Expand Up @@ -507,8 +510,9 @@ class Login extends PureComponent {
<ErrorBoundary navigation={this.props.navigation} view="Login">
<SafeAreaView style={styles.mainWrapper}>
<KeyboardAwareScrollView
style={styles.wrapper}
keyboardShouldPersistTaps="handled"
resetScrollToCoords={{ x: 0, y: 0 }}
style={styles.wrapper}
>
<View testID={LoginViewSelectors.CONTAINER}>
<View style={styles.foxWrapper}>
Expand Down

0 comments on commit aea73a4

Please sign in to comment.