Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signatures remain pending whenever tapping outside the modal #6936

Merged

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Jul 31, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add the appropiate QA label when dev review is completed
    • needs-qa: PR requires manual QA.
    • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
    • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)

Description

On signature requests whenever users tap outside the approval request remains open, this issue was fixed by #6687 and #6600. The only remaining action is to match the signature modal with the transaction modal behavior. Now, when users click outside the signature modal nothing happens as in the transaction modal.

Screenshots/Recordings

sign_modal_backdrop_onpress.webm

E2E
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9957d254-c064-4fd3-856f-e3eed0894b0f

Issue

resolves #6855

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@vinistevam vinistevam requested a review from a team as a code owner July 31, 2023 10:59
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vinistevam vinistevam added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-confirmations-system DEPRECATED: please use "team-confirmations" label instead and removed team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Jul 31, 2023
@vinistevam vinistevam merged commit c2de64e into main Aug 1, 2023
24 checks passed
@vinistevam vinistevam deleted the fix/6855-signatures-remain-pediing-tap-outside-modal branch August 1, 2023 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.6.0 Issue or pull request that will be included in release 7.6.0
Projects
None yet
4 participants