feat: Update transaction controller to v7.1.0 #8628

tommasini · 2024-02-19T18:22:34Z

Description

This PR aims to update transaction controller to version 7.1.0, in order to complete the update to controllers version 61.

All the changes are present in this core branch for an easy review: patch/mobile-transaction-controller-7-1-0

Related issues

Fixes:

Manual testing steps

Performed EIP 1559 transaction
Performed sendflow transaction

Screenshots/Recordings

EIP 1559: https://recordit.co/m55xYCyBQX
Sendflow tx: https://recordit.co/T462M1VbYL

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-02-19T18:22:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-02-19T18:24:50Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/compat-data@7.22.20	None	`0`	64.1 kB	nicolo-ribaudo
npm/@babel/helper-module-transforms@7.23.3	Transitive: environment, filesystem, shell, unsafe	`+53`	13.3 MB	nicolo-ribaudo
npm/@babel/parser@7.24.0	None	`0`	1.88 MB	nicolo-ribaudo
npm/@babel/plugin-proposal-export-default-from@7.23.3	Transitive: environment, filesystem, unsafe	`+17`	9.37 MB	nicolo-ribaudo
npm/@babel/plugin-syntax-export-default-from@7.23.3	Transitive: environment, filesystem, unsafe	`+16`	9.36 MB	nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.23.3	Transitive: environment, filesystem, unsafe	`+16`	9.36 MB	nicolo-ribaudo
npm/@babel/plugin-syntax-typescript@7.23.3	Transitive: environment, filesystem, unsafe	`+16`	9.37 MB	nicolo-ribaudo
npm/@babel/plugin-transform-react-jsx@7.23.4	Transitive: environment, filesystem, unsafe	`+17`	9.44 MB	nicolo-ribaudo
npm/@babel/plugin-transform-typescript@7.23.6	Transitive: environment, filesystem, unsafe	`+18`	9.89 MB	nicolo-ribaudo
npm/@babel/preset-env@7.22.20	environment Transitive: filesystem, shell, unsafe	`+164`	17.7 MB	nicolo-ribaudo
npm/@babel/preset-typescript@7.23.3	Transitive: environment, filesystem, unsafe	`+21`	9.96 MB	nicolo-ribaudo
npm/@babel/register@7.23.7	environment, filesystem, unsafe	`+25`	9.48 MB	nicolo-ribaudo
npm/@babel/template@7.24.0	Transitive: environment	`+14`	2.18 MB	nicolo-ribaudo
npm/@babel/types@7.23.0	environment	`+3`	2.5 MB	nicolo-ribaudo
npm/@blockaid/ppom_release@1.4.4	network	`0`	3.08 MB	blockaiduser
npm/@cucumber/messages@22.0.0	None	`+3`	1.33 MB	cukebot
npm/@jridgewell/gen-mapping@0.3.5	None	`+4`	370 kB	jridgewell
npm/@jridgewell/set-array@1.2.1	None	`0`	17.9 kB	jridgewell
npm/@keystonehq/bc-ur-registry-eth@0.7.7	environment Transitive: eval, filesystem	`+67`	7.94 MB	soralit
npm/@keystonehq/metamask-airgapped-keyring@0.3.0	environment Transitive: eval, filesystem	`+83`	12.6 MB	soralit
npm/@metamask/eth-sig-util@4.0.1	Transitive: environment, filesystem	`+38`	6.66 MB	gudahtt
npm/@metamask/transaction-controller@7.1.0	Transitive: environment, eval, filesystem, network	`+124`	25.6 MB	metamaskbot
npm/@react-native-community/cli-platform-android@10.2.0	environment, filesystem, shell Transitive: network	`+50`	2.28 MB	thymikee
npm/@react-native-community/cli-platform-ios@10.2.5	environment, filesystem, shell Transitive: network	`+41`	1.52 MB	thymikee
npm/@react-navigation/native@5.9.4	Transitive: environment, eval, filesystem, network, shell, unsafe	`+329`	149 MB	satya164
npm/@types/estree@1.0.2	None	`0`	25.7 kB	types
npm/@types/json-schema@7.0.13	None	`0`	32.2 kB	types
npm/@types/react-native@0.64.13	None	`+3`	570 kB	types
npm/@types/semver@7.5.3	None	`0`	23.8 kB	types
npm/@typescript-eslint/eslint-plugin@5.62.0	Transitive: environment, filesystem, unsafe	`+47`	77.5 MB	jameshenry
npm/@typescript-eslint/parser@5.62.0	Transitive: environment, filesystem, unsafe	`+37`	72.2 MB	jameshenry
npm/@wdio/cli@7.32.4	environment, filesystem, shell Transitive: eval, network, unsafe	`+218`	97 MB	wdio-user
npm/appium-adb@9.14.11	environment, filesystem, network Transitive: eval, shell, unsafe	`+205`	29.7 MB	kazucocoa
npm/array-includes@3.1.6	Transitive: eval	`+54`	4.26 MB	ljharb
npm/array.prototype.flat@1.3.1	Transitive: eval	`+55`	4.27 MB	ljharb
npm/base-64@1.0.0	None	`0`	10.9 kB	mathias
npm/body-parser@1.20.1	network Transitive: environment, eval, filesystem, unsafe	`+24`	893 kB	dougwilson
npm/browserslist@4.23.0	environment, filesystem Transitive: shell	`+6`	2.4 MB	ai
npm/buffer@5.2.1	None	`0`	79.9 kB	feross
npm/caniuse-lite@1.0.30001594	None	`0`	1.99 MB	caniuse-lite
npm/chokidar@3.5.3	environment, filesystem	`+11`	499 kB	paulmillr
npm/core-js-compat@3.32.2	Transitive: environment, filesystem, shell	`+7`	3.08 MB	zloirock
npm/d3-shape@3.2.0	None	`+1`	268 kB	mbostock
npm/electron-to-chromium@1.4.693	None	`0`	278 kB	kilianvalkhof
npm/envinfo@7.11.0	environment, eval, filesystem, shell	`0`	162 kB	tabrindle
npm/enzyme@3.9.0	Transitive: eval, network	`+86`	7.9 MB	ljharb
npm/eslint-plugin-import@2.27.5	filesystem, unsafe Transitive: environment, eval	`+81`	7.76 MB	ljharb
npm/eslint-plugin-jsdoc@39.9.1	Transitive: environment, filesystem, unsafe	`+17`	3.96 MB	gajus
npm/eslint-plugin-react-native@4.0.0	Transitive: environment, filesystem, unsafe	`+19`	6.94 MB	tomhastjarjanto
npm/eslint-plugin-react@7.16.0	Transitive: environment, eval, filesystem, shell, unsafe	`+112`	12.6 MB	ljharb
npm/eth-json-rpc-errors@2.0.2	None	`+1`	76.3 kB	rekmarks
npm/eth-json-rpc-middleware@4.3.0	Transitive: environment, eval, filesystem, network	`+90`	13.3 MB	danfinlay
npm/ethereumjs-abi@0.6.6	Transitive: environment, filesystem	`+34`	6.23 MB	holgerd77
npm/ethereumjs-util@6.1.0	Transitive: environment, filesystem	`+28`	2.19 MB	holgerd77
npm/ethjs-contract@0.2.3	None	`+6`	1.69 MB	silentcicero
npm/events@3.0.0	None	`0`	72 kB	goto-bus-stop
npm/fast-xml-parser@4.2.4	None	`+1`	122 kB	amitgupta
npm/html-inline-script-webpack-plugin@3.2.1	Transitive: environment, eval, filesystem, network, shell, unsafe	`+107`	23.1 MB	icelam
npm/https-browserify@0.0.1	network	`0`	2.28 kB	feross
npm/ignore@5.3.1	None	`0`	51.5 kB	kael
npm/internal-slot@1.0.5	Transitive: eval	`+7`	245 kB	ljharb
npm/is-array-buffer@3.0.2	Transitive: eval	`+12`	251 kB	ljharb
npm/json-rpc-middleware-stream@3.0.0	Transitive: environment	`+4`	130 kB	rekmarks
npm/metro-config@0.73.10	filesystem Transitive: environment, eval, network, shell, unsafe	`+157`	23.6 MB	metro-bot
npm/multihashes@0.4.14	None	`+1`	49.8 kB	daviddias
npm/node-releases@2.0.14	None	`0`	34 kB	chicoxyzzy
npm/object.assign@4.1.4	Transitive: eval	`+9`	1.36 MB	ljharb
npm/prop-types@15.7.2	environment	`+3`	133 kB	ljharb
npm/qs@6.7.3	None	`0`	159 kB	ljharb
npm/react-native-gesture-handler@1.10.3	Transitive: environment, network	`+20`	3.71 MB	jgonet
npm/react-native-get-random-values@1.8.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+322`	147 MB	linusu
npm/react-native-modal@12.1.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+323`	147 MB	mmazzarolo
npm/react-native-safe-area-context@3.4.1	Transitive: environment, eval, filesystem, network, shell, unsafe	`+321`	147 MB	janicduplessis
npm/react-native-screens@3.19.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+323`	148 MB	kkafar
npm/react-native-svg@12.1.1	network Transitive: environment, eval, filesystem, shell, unsafe	`+329`	151 MB	magicismight
npm/react-native-swipe-gestures@1.0.3	None	`0`	9.55 kB	sverps
npm/react-native-url-polyfill@1.3.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+324`	147 MB	charpeni
npm/react-native@0.71.15	environment, network Transitive: eval, filesystem, shell, unsafe	`+320`	147 MB	react-native-bot
npm/readable-stream@2.3.7	environment	`+3`	120 kB	matteo.collina
npm/redux@4.1.1	environment	`+1`	416 kB	timdorr
npm/regenerator-runtime@0.13.9	None	`0`	27.4 kB	benjamn
npm/regexp.prototype.flags@1.5.1	Transitive: eval	`+11`	263 kB	ljharb
npm/resolve@1.22.6	environment, filesystem	`+5`	216 kB	ljharb
npm/safe-array-concat@1.0.1	Transitive: eval	`+6`	129 kB	ljharb
npm/through2@3.0.1	Transitive: environment	`+4`	137 kB	rvagg
npm/url-parse@1.5.9	None	`+2`	77.8 kB	swaagie
npm/url@0.11.0	None	`+2`	133 kB	defunctzombie
npm/zxcvbn@4.4.2	None	`0`	3.46 MB	wheels

View full report↗︎

socket-security · 2024-02-19T18:24:53Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@ampproject/remapping@2.3.0, npm/@babel/compat-data@7.22.20, npm/@babel/compat-data@7.23.5, npm/@babel/core@7.24.0, npm/@babel/helper-compilation-targets@7.23.6, npm/@babel/helper-define-polyfill-provider@0.4.2, npm/@babel/helper-module-transforms@7.23.3, npm/@babel/helper-validator-option@7.23.5, npm/@babel/helpers@7.24.0, npm/@babel/parser@7.24.0, npm/@babel/plugin-proposal-export-default-from@7.23.3, npm/@babel/plugin-syntax-export-default-from@7.23.3, npm/@babel/plugin-syntax-jsx@7.23.3, npm/@babel/plugin-syntax-typescript@7.23.3, npm/@babel/plugin-transform-async-generator-functions@7.22.15, npm/@babel/plugin-transform-modules-commonjs@7.23.3, npm/@babel/plugin-transform-object-assign@7.23.3, npm/@babel/plugin-transform-react-jsx@7.23.4, npm/@babel/plugin-transform-typescript@7.23.6, npm/@babel/preset-env@7.22.20, npm/@babel/preset-typescript@7.23.3, npm/@babel/register@7.23.7, npm/@babel/runtime@7.23.1, npm/@babel/template@7.24.0, npm/@babel/traverse@7.24.0, npm/@babel/types@7.23.0, npm/@babel/types@7.24.0, npm/@blockaid/ppom_release@1.4.4, npm/@cucumber/messages@22.0.0, npm/@jimp/plugin-color@0.22.12, npm/@jridgewell/gen-mapping@0.3.5, npm/@jridgewell/set-array@1.2.1, npm/@keystonehq/base-eth-keyring@0.3.2, npm/@keystonehq/base-eth-keyring@0.4.0, npm/@keystonehq/bc-ur-registry-eth@0.7.7, npm/@keystonehq/bc-ur-registry-eth@0.9.0, npm/@keystonehq/bc-ur-registry@0.5.0-alpha.5, npm/@keystonehq/metamask-airgapped-keyring@0.2.2, npm/@keystonehq/metamask-airgapped-keyring@0.3.0, npm/@ledgerhq/cryptoassets@6.37.0, npm/@ledgerhq/hw-app-eth@6.26.1, npm/@metamask/eth-sig-util@4.0.1, npm/@metamask/transaction-controller@7.1.0, npm/@react-native-community/cli-clean@10.1.1, npm/@react-native-community/cli-config@10.1.1, npm/@react-native-community/cli-debugger-ui@10.0.0, npm/@react-native-community/cli-doctor@10.2.5, npm/@react-native-community/cli-hermes@10.2.0, npm/@react-native-community/cli-platform-android@10.2.0, npm/@react-native-community/cli-platform-ios@10.2.5, npm/@react-native-community/cli-plugin-metro@10.2.3, npm/@react-native-community/cli-server-api@10.1.1, npm/@react-native-community/cli-tools@10.1.1, npm/@react-native-community/cli-types@10.0.0, npm/@react-native-community/cli@10.2.6, npm/@react-navigation/core@5.15.3, npm/@react-navigation/native@5.9.4, npm/@react-navigation/routers@5.7.2, npm/@types/eslint-scope@3.7.5, npm/@types/eslint@8.44.3, npm/@types/estree@1.0.2, npm/@types/json-schema@7.0.13, npm/@types/node@20.7.1, npm/@types/npmlog@4.1.6, npm/@types/react-native@0.64.13, npm/@types/semver@7.5.3, npm/@types/uuid@9.0.1, npm/@typescript-eslint/eslint-plugin@5.62.0, npm/@typescript-eslint/parser@5.62.0, npm/@wdio/cli@7.32.4, npm/appium-adb@9.14.11, npm/array-buffer-byte-length@1.0.0, npm/array-includes@3.1.6, npm/array.prototype.filter@1.0.0, npm/array.prototype.flat@1.3.1, npm/arraybuffer.prototype.slice@1.0.2, npm/babel-plugin-polyfill-corejs2@0.4.5, npm/babel-plugin-polyfill-corejs3@0.8.4, npm/babel-plugin-polyfill-regenerator@0.5.2, npm/base-64@1.0.0, npm/body-parser@1.20.1, npm/browserslist@4.23.0, npm/buffer@5.2.1, npm/caniuse-lite@1.0.30001594, npm/chokidar@3.5.3, npm/chrome-launcher@0.15.1, npm/core-js-compat@3.32.2, npm/css-select@2.1.0, npm/css-what@3.4.2, npm/d3-path@3.1.0, npm/d3-shape@3.2.0, npm/deprecated-react-native-prop-types@3.0.2, npm/dom-serializer@0.2.2, npm/domelementtype@1.3.1, npm/domutils@1.7.0, npm/electron-to-chromium@1.4.693, npm/envinfo@7.11.0, npm/enzyme@3.9.0, npm/es-set-tostringtag@2.0.1, npm/es-shim-unscopables@1.0.0, npm/eslint-import-resolver-node@0.3.7, npm/eslint-module-utils@2.7.4, npm/eslint-plugin-import@2.27.5, npm/eslint-plugin-jsdoc@39.9.1, npm/eslint-plugin-react-native@4.0.0, npm/eslint-plugin-react@7.16.0, npm/eslint-utils@1.4.3, npm/eslint@6.8.0, npm/espree@6.2.1, npm/eth-json-rpc-errors@2.0.2, npm/eth-json-rpc-middleware@4.3.0, npm/ethereumjs-abi@0.6.6, npm/ethereumjs-util@6.1.0, npm/ethjs-contract@0.2.3, npm/events@3.0.0, npm/fast-xml-parser@4.2.4, npm/file-entry-cache@5.0.1, npm/flat-cache@2.0.1, npm/flat-cache@3.1.0, npm/flatted@2.0.2, npm/flatted@3.2.9, npm/get-symbol-description@1.0.0, npm/glob@10.3.10, npm/globals@12.4.0, npm/globals@13.22.0, npm/html-inline-script-webpack-plugin@3.2.1, npm/https-browserify@0.0.1, npm/ignore@5.3.1, npm/ini@4.1.1, npm/inquirer@7.3.3, npm/internal-slot@1.0.5, npm/is-array-buffer@3.0.2, npm/is-core-module@2.13.0, npm/is-negative-zero@2.0.2, npm/is-shared-array-buffer@1.0.2, npm/jest-get-type@26.3.0, npm/jest-regex-util@27.5.1, npm/jest-validate@26.6.2, npm/json-rpc-middleware-stream@3.0.0, npm/jsx-ast-utils@2.4.1, npm/keccak@1.4.0, npm/keyv@4.5.3, npm/levn@0.3.0, npm/metro-cache-key@0.73.10, npm/metro-cache@0.73.10, npm/metro-config@0.73.10, npm/metro-core@0.73.10, npm/metro-file-map@0.73.10, npm/metro-minify-terser@0.73.10, npm/metro-resolver@0.73.10, npm/metro-runtime@0.73.10, npm/metro-transform-plugins@0.73.10, npm/metro-transform-worker@0.73.10, npm/metro@0.73.10, npm/multihashes@0.4.14, npm/node-releases@2.0.14, npm/object.assign@4.1.4, npm/optionator@0.8.3, npm/optionator@0.9.1, npm/pkginfo@0.4.1, npm/prelude-ls@1.1.2, npm/prop-types@15.7.2, npm/punycode@1.3.2, npm/qs@6.7.3, npm/raw-body@2.5.1, npm/react-devtools-core@4.28.4, npm/react-native-gesture-handler@1.10.3, npm/react-native-get-random-values@1.8.0, npm/react-native-modal@12.1.0, npm/react-native-safe-area-context@3.4.1, npm/react-native-screens@3.19.0, npm/react-native-svg@12.1.1, npm/react-native-svg@7.2.1, npm/react-native-swipe-gestures@1.0.3, npm/react-native-url-polyfill@1.3.0, npm/react-native@0.71.15, npm/readable-stream@2.3.7, npm/redux@4.1.1, npm/regenerate-unicode-properties@10.1.1, npm/regenerator-runtime@0.13.9, npm/regexp.prototype.flags@1.5.1, npm/regexpp@2.0.1, npm/resolve@1.22.6, npm/safe-array-concat@1.0.1, npm/safe-regex-test@1.0.0, npm/secp256k1@3.8.0, npm/simple-plist@1.4.0, npm/table@5.4.6, npm/teen_process@2.0.37, npm/through2@3.0.1, npm/tinycolor2@1.4.2, npm/tsconfig-paths@3.14.1, npm/type-check@0.3.2, npm/typed-array-buffer@1.0.0, npm/typed-array-byte-length@1.0.0, npm/typed-array-byte-offset@1.0.0, npm/typed-array-length@1.0.4, npm/url-parse@1.5.9, npm/url@0.11.0, npm/zxcvbn@4.4.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

github-actions · 2024-02-19T18:24:55Z

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0147c05b-2258-44df-9c1f-02187873d06f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

codecov-commenter · 2024-02-19T18:33:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.66%. Comparing base (12e1415) to head (a3a5646).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8628   +/-   ##
=======================================
  Coverage   41.66%   41.66%           
=======================================
  Files        1271     1271           
  Lines       30906    30906           
  Branches     3088     3088           
=======================================
  Hits        12877    12877           
  Misses      17250    17250           
  Partials      779      779

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tommasini · 2024-02-19T19:20:30Z

@SocketSecurity ignore npm/@metamask/transaction-controller@7.1.0

It seems that the issue presented on this version, were already existing (detected when core repo converted to mono repo) and with an ethereumjs lib that we currently use and test

sleepytanya · 2024-02-20T03:11:08Z

MarioAslau

LGTM

github-actions · 2024-03-04T13:21:19Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d07c78f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cce485ce-c262-4907-99d0-15b131f8caec

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini · 2024-03-05T11:04:49Z

This branch is awaiting changes to the transaction controller

Once this work is updated on the respective core branch: patch/mobile-transaction-controller-7-1-0 this work will be ready for testing again

… update

github-actions · 2024-03-06T12:50:37Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4be6a89
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1d1f275d-4259-44c1-aa09-4eb943fa8d25

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L

LGTM, would be great if we can get a second pair of eyes WRT the patches as well. cc @matthewwalsh0

sonarcloud · 2024-03-07T01:12:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sleepytanya · 2024-03-07T01:47:54Z

Transactions regression passed.
Updated usage of OP Goerli to OP Sepolia works as expected:

goerliSep.mp4

tommasini · 2024-03-07T10:18:30Z

@SocketSecurity ignore-all
It seems that no packages were added/removed/updated during this updated to transaction controller

Update transaction controller to v7.1.0

1b49f2e

tommasini requested a review from a team as a code owner February 19, 2024 18:22

tommasini added the team-mobile-platform label Feb 19, 2024

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 19, 2024

sleepytanya added the QA Passed A successful QA run through has been done label Feb 20, 2024

tommasini and others added 2 commits February 20, 2024 10:30

replace cancel transaction to processApproval on Ledger confirmation

612cd49

Merge branch 'main' into feat/1538-transaction-controller-v7.1

5199c9d

MarioAslau previously approved these changes Feb 20, 2024

View reviewed changes

rever processTransaction method to cancelTransaction for now

d1661d8

tommasini dismissed MarioAslau’s stale review via d1661d8 February 22, 2024 16:51

tommasini added 2 commits March 4, 2024 11:52

update transaction controller patch with new gas features

a1da8c6

merge main and solve conflicts

d07c78f

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 4, 2024

tommasini added 2 commits March 6, 2024 12:30

merge main and solve conflicts

fcc3cb0

update with the latest work of linea gas feature and optimism sepolia…

4be6a89

… update

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2024

Cal-L previously approved these changes Mar 6, 2024

View reviewed changes

merge main and solve conflicts

a3a5646

tommasini dismissed Cal-L’s stale review via a3a5646 March 7, 2024 00:58

matthewwalsh0 approved these changes Mar 7, 2024

View reviewed changes

tommasini merged commit 9cf7630 into main Mar 7, 2024
28 of 29 checks passed

tommasini deleted the feat/1538-transaction-controller-v7.1 branch March 7, 2024 10:20

github-actions bot locked and limited conversation to collaborators Mar 7, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024

metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update transaction controller to v7.1.0 #8628

feat: Update transaction controller to v7.1.0 #8628

tommasini commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024

socket-security bot commented Feb 19, 2024 •

edited

socket-security bot commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024

codecov-commenter commented Feb 19, 2024 •

edited

tommasini commented Feb 19, 2024

sleepytanya commented Feb 20, 2024 •

edited

MarioAslau left a comment

github-actions bot commented Mar 4, 2024 •

edited by metamaskbot

tommasini commented Mar 5, 2024

github-actions bot commented Mar 6, 2024 •

edited by metamaskbot

Cal-L left a comment

sonarcloud bot commented Mar 7, 2024

sleepytanya commented Mar 7, 2024

tommasini commented Mar 7, 2024 •

edited

feat: Update transaction controller to v7.1.0 #8628

feat: Update transaction controller to v7.1.0 #8628

Conversation

tommasini commented Feb 19, 2024 • edited

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 19, 2024

socket-security bot commented Feb 19, 2024 • edited

socket-security bot commented Feb 19, 2024 • edited

Next steps

github-actions bot commented Feb 19, 2024

codecov-commenter commented Feb 19, 2024 • edited

Codecov Report

tommasini commented Feb 19, 2024

sleepytanya commented Feb 20, 2024 • edited

MarioAslau left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 4, 2024 • edited by metamaskbot

Bitrise

tommasini commented Mar 5, 2024

github-actions bot commented Mar 6, 2024 • edited by metamaskbot

Bitrise

Cal-L left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 7, 2024

Quality Gate passed

sleepytanya commented Mar 7, 2024

tommasini commented Mar 7, 2024 • edited

tommasini commented Feb 19, 2024 •

edited

socket-security bot commented Feb 19, 2024 •

edited

socket-security bot commented Feb 19, 2024 •

edited

codecov-commenter commented Feb 19, 2024 •

edited

sleepytanya commented Feb 20, 2024 •

edited

github-actions bot commented Mar 4, 2024 •

edited by metamaskbot

github-actions bot commented Mar 6, 2024 •

edited by metamaskbot

tommasini commented Mar 7, 2024 •

edited