Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: url bar no longer shown in the tab thumnail list view #9495

Merged
merged 20 commits into from
May 8, 2024
Merged

feat: url bar no longer shown in the tab thumnail list view #9495

merged 20 commits into from
May 8, 2024

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented May 1, 2024 •
edited
Loading

Description

This pull request eliminates the URL top bar from the tab thumbnails screen, which previously displayed the network and URL of the selected tab thumbnail.

The rationale behind this removal is to introduce a new footer for the tab thumbnails, which will display their network information. This addition is facilitated through this PR here, which also includes screenshots illustrating the new footer on each tab thumbnail.

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/66/views/1?pane=issue&itemId=57737399

Manual testing steps

Please follow these improved steps, which are also included in this pull request:

  1. Navigate to the in-app browser and tap on the square icon that contains a number to view the list of open tabs.
  2. On this tab thumbnails list page, the URL top bar should no longer be visible.
  3. Upon clicking on a thumbnail, the tab will expand to full screen, at which point the URL top bar is expected to reappear.

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 added team-wallet-ux Run Smoke E2E Triggers smoke e2e on Bitrise labels May 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f1f35ac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56ad7864-cfe9-4360-a037-cc46351f5379

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 added needs-smoke-e2e and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 2, 2024
@EtherWizard33 EtherWizard33 marked this pull request as ready for review May 2, 2024 15:39
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner May 2, 2024 15:39
darkwing
darkwing previously approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but left a comment that I think would be useful either just answering here or making them constants somewhere in the codebase.

app/components/UI/Tabs/index.js Outdated Show resolved Hide resolved
@EtherWizard33 EtherWizard33 requested a review from Cal-L May 2, 2024 19:55
@EtherWizard33 EtherWizard33 requested a review from Cal-L May 3, 2024 17:21
darkwing
darkwing previously approved these changes May 7, 2024
View reviewed changes
@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 7, 2024
Cal-L
Cal-L previously approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 28bf16b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a2372150-e69a-4874-b15b-2de2e1a8372a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 dismissed stale reviews from Cal-L and darkwing via 81e1232 May 7, 2024 21:48
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 81e1232
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/acfc4f13-698a-4818-aa40-8d1741540259

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1b7a29c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6e60fd0-5f2c-433f-9302-4bf1d4d3d5cb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@EtherWizard33 EtherWizard33 merged commit 4142037 into main May 8, 2024
31 checks passed
@EtherWizard33 EtherWizard33 deleted the feature/1635-remove-tab-header-from-tab-selector-view-but-keep-in-full-screen-view branch May 8, 2024 20:28
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frankvonhoven frankvonhoven frankvonhoven left review comments

@darkwing darkwing darkwing approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
needs-smoke-e2e release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EtherWizard33 @darkwing @Cal-L @frankvonhoven @metamaskbot