Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-1193 endowment permission #908

Closed
rekmarks opened this issue Nov 3, 2022 · 1 comment · Fixed by #939
Closed

Add EIP-1193 endowment permission #908

rekmarks opened this issue Nov 3, 2022 · 1 comment · Fixed by #939
Assignees
@FrederikBolding

Comments

@rekmarks
Copy link
Member

rekmarks commented Nov 3, 2022

Add an endowment permission for injecting and EIP-1193 provider globalThis.ethereum in snaps.

Related: #891
@FrederikBolding
Copy link
Member

I don't think we can do this until we separate the Snaps API from the EIP-1193 provider.

@FrederikBolding FrederikBolding self-assigned this Nov 8, 2022
@FrederikBolding FrederikBolding mentioned this issue Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: Remove wallet global in favor of snaps and ethereum MetaMask/snaps
2 participants
@FrederikBolding @rekmarks