All Attributes: delete empty items at database

[zonky2]

Checklist:

I confirm that:

• I have tested this with the latest version available
• I have read documentation @ http://metamodels.readthedocs.org/en/ or http://metamodels.readthedocs.org/de/
• I have checked the Contao community forums for references https://community.contao.org/
• I have checked existing issues for duplicates and found none @ https://github.com/MetaModels/core/issues?q=is%3Aissue

My environment is:

Key	Value	Comments
PHP version:	5.6
Contao version:	3.5.8
MetaModels version:	2.0.0 a10
Installation via composer	yes
Installed MetaModels packages	bundle_all

Issue description

if you clear a existing complex/translated item e.g. attribute_translatedtext we have a empty item at database - see screenshot below

e.g. the same MetaModels/attribute_translatedurl#4

Steps to reproduce

1. multilanguage MM with translated text
2. fill at input mask and save
3. delete the text at input mask and save
4. look at database...

Screenshots

Check and update

• attribute_tabletext (PR Hotfix #15 clear empty rows at database attribute_tabletext#19)
• attribute_url (PR Hotfix save NULL at empty values attribute_url#14)
• attribute_translatedurl (PR Hotfix #4 delete empty rows attribute_translatedurl#8)
• attribute_tags
• attribute_translatedalias
• attribute_translatedcheckbox (PR Hotfix #1005 delete empty items #1117)
• attribute_translatedcombinedvalues (PR Hotfix #1005 delete empty items #1117)
• attribute_translatedfile (PR Hotfix delete empty items at DB attribute_translatedfile#15)
• attribute_translatedlongtext (PR Hotfix #1005 delete empty items #1117)
• attribute_translatedselect
• attribute_translatedtabletext (PR Hotfix #18 delete empty rows attribute_translatedtabletext#19)
• attribute_translatedtags
• attribute_translatedtext (PR Hotfix #1005 delete empty items #1117)

[johannes-bittner]

Soweit schon einmal geprüft und nicht funktionierend:
attribute_translatedtext => Eintrag bleibt stehen
attribute_translatedcheckbox => Eintrag bleibt stehen
attribute_translatedcombinedvalues => Eintrag bleibt stehen
attribute_translatedfile => Eintrag bleibt stehen
attribute_translatedlongtext => Eintrag bleibt stehen
attribute_translatedtabletext => Eintrag bleibt stehen

[johannes-bittner]

with PR #1117

attribute_translatedtext => OK
attribute_translatedcheckbox => OK
attribute_translatedtabletext => OK
attribute_translatedlongtext => OK
attribute_translatedcombinedvalues => OK

[zonky2]

setTranslatedDataFor at https://github.com/MetaModels/core/blob/master/src/MetaModels/Attribute/TranslatedReference.php#L299 should implement at all attributes as own method

[zonky2]

with PR MetaModels/attribute_translatedfile#15
attribute_translatedfile => OK

[johannes-bittner]

• attribute_tabletext (PR Hotfix #15 clear empty rows at database attribute_tabletext#19)
• attribute_url (PR Hotfix save NULL at empty values attribute_url#14)
• attribute_translatedurl (PR Hotfix #4 delete empty rows attribute_translatedurl#8)
• attribute_tags
• attribute_translatedalias
• attribute_translatedcheckbox (PR Hotfix #1005 delete empty items #1117)
• attribute_translatedcombinedvalues (PR Hotfix #1005 delete empty items #1117)
• attribute_translatedfile (PR Hotfix delete empty items at DB attribute_translatedfile#15)
• attribute_translatedlongtext (PR Hotfix #1005 delete empty items #1117)
• attribute_translatedtabletext (PR Hotfix #18 delete empty rows attribute_translatedtabletext#19)
• attribute_translatedtags
• attribute_translatedtext (PR Hotfix #1005 delete empty items #1117)

[zonky2]

@discordier || @stefanheimes pls merge the linked PRs

[baumannsven]

Merged in 76e6216

[zonky2]

thx