Hotfix #4 delete empty rows #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
discordier
requested changes
Dec 8, 2016
| @@ -218,6 +221,9 @@ public function setTranslatedDataFor($values, $language) | |||
| $time = time(); | |||
| $params = array(); | |||
| foreach ($values as $id => $value) { | |||
| if (!count(array_filter((array)$value))) { | |||
There was a problem hiding this comment.
This will break the query which is built above.
You must filter before building the query string.
I suggest creating the $sql after determining the parameters.
zonky2
force-pushed
the
Hotfix_#4_delete_empty_rows
branch
from
944fda6
to
1a1005f
Compare
zonky2
force-pushed
the
Hotfix_#4_delete_empty_rows
branch
from
1a1005f
to
52a1a9d
Compare
discordier
approved these changes
Dec 8, 2016
|
test at current MM - works fine! |
discordier
added a commit
that referenced
this pull request
Dec 15, 2016
Fixes #4 - remove empty rows and allow null values for href..
|
Merged in 926fdb5 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix #4 delete empty rows respectively don´t save empty values