Fix duplicate files not imported, and other fixes

[sebastian-ruiz]

This should fix at least issues: #289, #246, #239 and #253.

The main inspiration for this fix comes from: sass/node-sass#2556

which says to add file parameter even when passing comment, like so:

done({ contents: fs.readFileSync(parsed.path, 'utf8'), file: parsed.path});

[sebakerckhof]

Hi @sebastian-ruiz . Thanks for the PR.
However, I do remember trying setting both file and data and that there used to be issues with this: sass/node-sass#1195 . But that's a long time ago and I'll check again if this is now a valid approach. It would indeed help us determine which file is being processed, since now sometimes it comes down to guessing.

[sebastian-ruiz]

Yes I saw sass/node-sass#1195. I assume things changed between then and sass/node-sass#2556 which allows for this fix.

With this PR I'm able to use stuff like bootstrap, font-awesome, and react libraries from NPM together without issues. This wasn't possible before because of conflicting variables.scss files and things like that.

[sebakerckhof]

Looks like providing both contents and file now works indeed. Nice find. I think with that the code could be simplified quite a bit. But for don't really have time to look into this further at the moment. Tests pass locally, so I'll release this as is so those bugs are fixed at least.

[sebakerckhof]

Included in 4.14.1, thanks