-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom test framework to cargo test
!
#41
Use custom test framework to cargo test
!
#41
Conversation
We should do that first. There is surely a way to get the target path of the test executable. |
Ok, I think I've found the relevant details needed to make it work in |
We absolutely need this, and have to start putting a lot of tests in |
Sorry for the lack of updates here, I was away for the weekend and didn't have any time to work on it. Hoping to get to update this PR to address concerns this week and try to get this merged. |
- Switch to single-threaded test and fix thread-local hashmap issue. - Use apt loop instead of `loop {}` , and wait for vblank. - Remove extraneous pthread stub.
Pushed a set of changes based on feedback, I still need to do the |
}) | ||
.unwrap() | ||
.join() | ||
.expect_err("should have panicked"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit weird, hence the large comment, and relies on some implementation details of std
, which I don't love. Here is the output I was referencing:
Perhaps it makes more sense to remove this test case entirely, since we don't necessarily care if HashMap::new
panics, but we do want the positive test case of being able to construct one when we have initialized PS. Let me know what you think or if you have a cleaner suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this will be fixed once we move to std threads: rust-lang/rust#78227
I think we should keep this test regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't gotten a chance to actually test this, but it can merge before I get to it.
Closes #25 , I think...
This basically plugs in the default test framework with hardcoded options
You can test it manually like this until cargo-3ds has support (.elf filename with hash may be different):
For now I included the
Ps
changes since they seemed easy to plug into this, but I can take them out / wait for that to merge:Things that seem to work correctly:
Things that don't / won't work, as far as I know:
Things I haven't tested
Screenshots
Failed Test
All Passed