DietPi-Software | Replace youtube-dl with yt-dlp #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! |
MichaIng
reviewed
May 17, 2023
MichaIng
reviewed
May 17, 2023
|
Look good! I'll add changelog and meta stuff and then merge. What we can have another look at is the other install options:
|
MichaIng
changed the title
- CHANGELOG | youtube-dl: Since the development of the original youtube-dl project stalled for some years, we migrated to the well known actively developed fork "yt-dlp": https://github.com/yt-dlp/yt-dlp. If you installed youtube-dl before, you can migrate via reinstall: "dietpi-software reinstall 195". For backwards compatibility, the "youtube-dl" command will stay valid as a symlink to "yt-dlp", but there are some differences you should be aware about when doing the migration on your system: https://github.com/yt-dlp/yt-dlp#differences-in-default-behavior. Many thanks to @rgabbo for suggestion and @pulpe for implementing this change: #5670, #6380
MichaIng
approved these changes
May 17, 2023
|
Install tests run: https://github.com/MichaIng/DietPi/actions/runs/5007448222 |
disconn3ct
added a commit
to disconn3ct/DietPi
that referenced
this pull request
May 26, 2023
* dev: v8.18 v8.18 v8.18 v8.18 v8.18 v8.18 v8.18 v8.18 v8.18 v8.18 v8.18 v8.18 (MichaIng#6375) v8.18 (MichaIng#6380) v8.18 v8.18 v8.18 (MichaIng#6378)
This was referenced May 27, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion #6374
Should be ok to merge, tested on virtual dietpi.