Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update youtube-dl install url to nightly build fork #6374

Closed
wants to merge 1 commit into from
Closed

Update youtube-dl install url to nightly build fork #6374

wants to merge 1 commit into from

Conversation

pulpe
Copy link
Contributor

@pulpe pulpe commented May 10, 2023

As stated in ytdl-org/youtube-dl#31585 new release depends on solving certain issues.

Until then they "recommend" to update with a few solutions ytdl-org/youtube-dl#31530 (comment)

I think that simplest for us is to use nightly build fork. (it's one of the solutions)

@Joulinar
Copy link
Collaborator

thx for creating this PR. It's related to https://dietpi.com/forum/t/youtube-dl-uploaded-id-error/16816

@Joulinar Joulinar added the External bug 🐞 For bugs which are not caused by DietPi. label May 10, 2023
@Joulinar Joulinar added this to the v8.18 milestone May 10, 2023
@MichaIng
Copy link
Owner

Sorry but I do not think it is great to generally ship untested nightly versions by default only because the current stable release has currently an issue.

I see the problem that it is very good maintained, given that the last release is from 1.5 years ago, but probably it is better to migrate to a well maintained fork with actually tested releases? There is already a request for this: #5670

Last release from this March: https://github.com/yt-dlp/yt-dlp/releases
41k stars => trusted, compared to the 61 stars of the young nightly fork used here.

Can be implemented via api.github.com like we do for other GitHub release downloads.

@pulpe
Copy link
Contributor Author

pulpe commented May 11, 2023

Ok, i understand.

Can we than add yt-dlp to dietpi-software and leave youtube-dl there, maybe they will arise again someday?

I was thinking about symlink youtube-dl to yt-dlp, but there are some differences https://github.com/yt-dlp/yt-dlp#differences-in-default-behavior , so maybe not...

@MichaIng
Copy link
Owner

I would prefer to stick with one fork. I mean its simple to download another binary if really required. As there are some differences, we can show a warning to users on next DietPi update that youtube-dl will be replaced with yt-dlp when reinstalled, and add a link to these differences. For new installs it shouldn't matter anyway as the core functionality of course is the same.

@pulpe
Copy link
Contributor Author

pulpe commented May 11, 2023

I will open new pull as i am done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External bug 🐞 For bugs which are not caused by DietPi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants