Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed window update latency issue. #46

Closed
Michael-48 opened this issue Mar 1, 2024 · 2 comments · Fixed by #64
Closed

Fixed window update latency issue. #46

Michael-48 opened this issue Mar 1, 2024 · 2 comments · Fixed by #64
Assignees
Labels
bug Something isn't working

Comments

@Michael-48
Copy link
Collaborator

As originally fixed in 6fcbfa2, then reverted in b6e4cc3, this should not be fixed until UIFlexItems are released from beta by Roblox, because this change breaks the interoperability between Beta and Non-Beta versions of roblox which exist currently.

@Michael-48 Michael-48 added the bug Something isn't working label Mar 1, 2024
@Michael-48 Michael-48 self-assigned this Mar 1, 2024
@SirMallard
Copy link
Owner

SirMallard commented Jul 23, 2024

I've also changed the window title to use UIFlexItems, so I'll link it here for when it's out of beta. https://github.com/Michael-48/Iris/tree/title-flex

SirMallard added a commit that referenced this issue Jul 23, 2024
# Simple Fix to Widget Layout Issues
Although this was addressed in #46, I was unsatisfied with regenerating widgets because they became out of order. Instead, I decided to redesign the layout system so that it is trivial to change the order of sibling elements without affecting children or parents. This involves a counter within each parent widget which assigns the LayoutOrder property and can check for new widgets added.

The current way to check for a new widget is by comparing the widget ZIndex property against the parent's counter. This ensures that if the widget order changes, all that needs to be done is change the Instance LayoutOrder property, no regeneration required.

## Additions
- Changed the display order to use sibling ZIndex instead of a global ZIndex ordering.
- Added new ZOffset and ZUpdate parent widget properties which decide the LayoutOrder of children.
- Widgets will use a LayoutOrder relative to siblings only. This allows for dynamic reorganising of widgets.
- Widgets will check that their ZIndex matches an expected value, otherwise causing a reshuffling of widgets.

## Tweaks and fixes
- Removed unnecessary ZIndex and LayoutOrder assignments for all widgets.
@SirMallard
Copy link
Owner

Seeing as Flex has been released to clients, I think we can start using them regularly. I'll push everything through with this then.

@SirMallard SirMallard linked a pull request Aug 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants