[Issue]: When any number of subtitles fail to download, the final count returns inaccurate values

[rDamascena]

Confirmations

• I have checked the issues tab, and couldn't find an existing open issue for the issue I want to report.

OS Type

Windows

Python Version

3.10.11

Package Version

2.5.3

Description

The number of failures is also subtracted from the total amount of matching subtitles available for download, always returning equivalent amounts.

For example: if the total amount of matching subtitles is 40 and there are 2 failures, the final count (downloaded subtitles/matching subtitles available), which should be 38/40, returns 38/38, and so on. The quantities always match, as if all available matching subtitles had been downloaded correctly, regardless of the number of failures.

The total amount of matching subtitles in the example below is 92 and there are 3 failures.

Expected result:

89/92 matching subtitles have been successfully downloaded.

But it returns:

89/89 matching subtitles have been successfully downloaded.

Output Log

$ isubrip "https://tv.apple.com/br/movie/napoleao/umc.cmc.25k80oxl3vo69c8rimk8v81s1"
User config file detected at 'C:\Users\Adriana\.isubrip\config.toml' and will be used.
Scraping 'https://tv.apple.com/br/movie/napoleao/umc.cmc.25k80oxl3vo69c8rimk8v81s1'...
Found movie: Napoleon [2023] (ID: 1720014471)
العربية (ar) subtitles were successfully downloaded.
български (bg) subtitles were successfully downloaded.
中文（简体） (cmn-Hans) subtitles were successfully downloaded.
中文（繁體） (cmn-Hant) subtitles were successfully downloaded.
Čeština (cs) subtitles were successfully downloaded.
dansk (da) subtitles were successfully downloaded.
Deutsch (de) subtitles were successfully downloaded.
Deutsch (de) [Forced] subtitles were successfully downloaded.
Ελληνικά (el) subtitles were successfully downloaded.
English (en) subtitles were successfully downloaded.
English (en) [Forced] subtitles were successfully downloaded.
Español (Latinoamérica) (es-419) subtitles were successfully downloaded.
Español (Latinoamérica) (es-419) [Forced] subtitles were successfully downloaded.
Español (España) (es-ES) subtitles were successfully downloaded.
Español (España) (es-ES) [Forced] subtitles were successfully downloaded.
eesti (et) subtitles were successfully downloaded.
Suomi (fi) subtitles were successfully downloaded.
Français (Canada) (fr-CA) subtitles were successfully downloaded.
Français (Canada) (fr-CA) [Forced] subtitles were successfully downloaded.
Français (France) (fr-FR) subtitles were successfully downloaded.
Français (France) (fr-FR) [Forced] subtitles were successfully downloaded.
עברית (he) subtitles were successfully downloaded.
हिन्दी (hi) subtitles were successfully downloaded.
magyar (hu) subtitles were successfully downloaded.
Bahasa Indonesia (id) subtitles were successfully downloaded.
Italiano (it) subtitles were successfully downloaded.
Failed to download Italiano (it) subtitles. Skipping...
日本語 (ja) subtitles were successfully downloaded.
日本語 (ja) [Forced] subtitles were successfully downloaded.
한국어 (ko) subtitles were successfully downloaded.
lietuvių (lt) subtitles were successfully downloaded.
latviešu (lv) subtitles were successfully downloaded.
Bahasa Melayu (ms) subtitles were successfully downloaded.
Nederlands (nl) subtitles were successfully downloaded.
norsk (no) subtitles were successfully downloaded.
polski (pl) subtitles were successfully downloaded.
Português (Brasil) (pt-BR) subtitles were successfully downloaded.
Português (Brasil) (pt-BR) [Forced] subtitles were successfully downloaded.
Português (pt) subtitles were successfully downloaded.
Русский (ru) subtitles were successfully downloaded.
Русский (ru) [Forced] subtitles were successfully downloaded.
Slovenčina (sk) subtitles were successfully downloaded.
slovenščina (sl) subtitles were successfully downloaded.
Svenska (sv) subtitles were successfully downloaded.
தமிழ் (ta) subtitles were successfully downloaded.
తెలుగు (te) subtitles were successfully downloaded.
ไทย (th) subtitles were successfully downloaded.
Türkçe (tr) subtitles were successfully downloaded.
українська (uk) subtitles were successfully downloaded.
Tiếng Việt (vi) subtitles were successfully downloaded.
廣東話 (yue-Hant) subtitles were successfully downloaded.
العربية (ar) [CC] subtitles were successfully downloaded.
български (bg) [CC] subtitles were successfully downloaded.
中文（简体） (cmn-Hans) [CC] subtitles were successfully downloaded.
中文（繁體） (cmn-Hant) [CC] subtitles were successfully downloaded.
Čeština (cs) [CC] subtitles were successfully downloaded.
dansk (da) [CC] subtitles were successfully downloaded.
Deutsch (de) [CC] subtitles were successfully downloaded.
Ελληνικά (el) [CC] subtitles were successfully downloaded.
English (en) [CC] subtitles were successfully downloaded.
Español (Latinoamérica) (es-419) [CC] subtitles were successfully downloaded.
Español (España) (es-ES) [CC] subtitles were successfully downloaded.
eesti (et) [CC] subtitles were successfully downloaded.
Suomi (fi) [CC] subtitles were successfully downloaded.
Français (Canada) (fr-CA) [CC] subtitles were successfully downloaded.
Français (France) (fr-FR) [CC] subtitles were successfully downloaded.
עברית (he) [CC] subtitles were successfully downloaded.
हिन्दी (hi) [CC] subtitles were successfully downloaded.
magyar (hu) [CC] subtitles were successfully downloaded.
Bahasa Indonesia (id) [CC] subtitles were successfully downloaded.
Failed to download Italiano (it) subtitles. Skipping...
Failed to download 日本語 (ja) subtitles. Skipping...
한국어 (ko) [CC] subtitles were successfully downloaded.
lietuvių (lt) [CC] subtitles were successfully downloaded.
latviešu (lv) [CC] subtitles were successfully downloaded.
Bahasa Melayu (ms) [CC] subtitles were successfully downloaded.
Nederlands (nl) [CC] subtitles were successfully downloaded.
norsk (no) [CC] subtitles were successfully downloaded.
polski (pl) [CC] subtitles were successfully downloaded.
Português (Brasil) (pt-BR) [CC] subtitles were successfully downloaded.
Português (pt) [CC] subtitles were successfully downloaded.
Русский (ru) [CC] subtitles were successfully downloaded.
Slovenčina (sk) [CC] subtitles were successfully downloaded.
slovenščina (sl) [CC] subtitles were successfully downloaded.
Svenska (sv) [CC] subtitles were successfully downloaded.
தமிழ் (ta) [CC] subtitles were successfully downloaded.
తెలుగు (te) [CC] subtitles were successfully downloaded.
ไทย (th) [CC] subtitles were successfully downloaded.
Türkçe (tr) [CC] subtitles were successfully downloaded.
українська (uk) [CC] subtitles were successfully downloaded.
Tiếng Việt (vi) [CC] subtitles were successfully downloaded.
廣東話 (yue-Hant) [CC] subtitles were successfully downloaded.
89/89 matching subtitles have been successfully downloaded.

Config

No response

[MichaelYochpaz]

Hey, thanks for reporting :)
The issue has been fixed on v2.5.4.