Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test App UI for common typed properties #835

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Test App UI for common typed properties #835

merged 4 commits into from
Oct 9, 2018

Conversation

guperrot
Copy link
Member

@guperrot guperrot commented Oct 9, 2018

device-2018-10-08-194426

@guperrot
Copy link
Member Author

guperrot commented Oct 9, 2018

To merge after #834

@guperrot
Reorder types in UI, and fix number logic in custom property
cfeae1a 
Also hide the value label for the clear custom property type.
@guperrot
Address some todos
fb80c4d
@guperrot guperrot changed the base branch from feature/common-typed-properties to feature/event-typed-properties October 9, 2018 19:10
@guperrot guperrot merged commit fffd360 into feature/event-typed-properties Oct 9, 2018
@guperrot guperrot deleted the feature/common-typed-properties-testapp branch October 9, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhei dhei dhei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guperrot @dhei