Add flags to trackEvent API #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Nov 1, 2018
| * @param flags Optional flags. Use {@link Flags#PERSISTENCE_CRITICAL} to send this event | ||
| * before events using that use default flags or {@link Flags#PERSISTENCE_NORMAL}. | ||
| */ | ||
| public static void trackEvent(String name, EventProperties properties, int flags) { |
There was a problem hiding this comment.
Something like @IntRange doesn't apply here?
There was a problem hiding this comment.
We don't use them for public APIs as it triggers warnings for people not having support annotations. So we validate and log at runtime everywhere in the SDK.
guperrot
changed the title
guperrot
changed the base branch from
feature/send-priority
to
feature/priority
jaeklim
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at our guidelines for contributions and consider the following before you submit the PR:
CHANGELOG.mdbeen updated?Description
Add flags to trackEvent that take EventProperties as a parameter.
Use Flags.DEFAULT_FLAGS for all previous signatures.