-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake Automatic Configuration #2111
Conversation
This file defines a single macro that attempts to autoconfigure chakracore.
The Shared Library for ChakraCore already contains all symbols needed. This means that most applications will only need symbols that are exported by libChakraCore.so or libChakraCore.dylib.
Hi @kphillisjr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
/cc @obastemur |
@dilijev and @obastemur, This does not include the major commit that resolves direct linking only to the ChakraCore shared library. The next commit provides a usable solution to issue #1811, but it breaks the ch utility in the process. This change is the following patch ( kphillisjr@75182f3 ), and to test this change on top of this pull request, run the following commands... #Download and get the right ChakraCore Source Tree.
git clone https://github.com/kphillisjr/ChakraCore.git
cd ChakraCore
git checkout fix_issue_1811
cd ..
# Download and get the correct Chakra Samples tree.
git clone https://github.com/kphillisjr/Chakra-Samples.git
cd Chakra-Samples
git checkout samples_cmake_v3
ln -s ../ChakraCore .
# Use the build script... It's a copy of what is in ChakraCore anyways.
./build.sh
# This BuildLinux/Debug will contain ChakraHelloWorld and ChakraOpenGLEngine
# that link directly to libChakraCore. Also both of these examples are
# functioning correctly. |
/cc @liminzhu - This pull request will definitely effect the ChakraCore samples. |
This is a rework for the ChakraCore automatic configuration. This is two patches that will allow many developers to quickly start developing using ChakraCore. I will be pushing a rework of the patches to the ChakraCore examples later, however the general process for this is as follows:
An example of how to use this is as follows...