Support for defer parse of object literal methods #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a straightforward modification to the defer-parse methods in the parser to enable them to know how to handle the object literal method grammar. Communicate the fact that the deferred function is a method via a parser flag - `fscrDeferredFncIsMethod`.
boingoing
force-pushed
the
DeferParseMethods
branch
from
1af92cb
to
7941e72
Compare
chakrabot
pushed a commit
that referenced
this pull request
Nov 4, 2017
…thods Merge pull request #4136 from boingoing:DeferParseMethods This is mostly a straightforward modification to the defer-parse methods in the parser to enable them to know how to handle the object literal method grammar. Communicate the fact that the deferred function is a method via a parser flag - `fscrDeferredFncIsMethod`.
|
Thank you 👍 |
chakrabot
pushed a commit
that referenced
this pull request
Nov 4, 2017
…ct literal methods Merge pull request #4136 from boingoing:DeferParseMethods This is mostly a straightforward modification to the defer-parse methods in the parser to enable them to know how to handle the object literal method grammar. Communicate the fact that the deferred function is a method via a parser flag - `fscrDeferredFncIsMethod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a straightforward modification to the defer-parse methods in the parser to enable them to know how to handle the object literal method grammar.
Communicate the fact that the deferred function is a method via a parser flag -
fscrDeferredFncIsMethod.