New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux-port] Enables the DXC main on Unix. #1384

Merged
merged 2 commits into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@ehsannas
Collaborator

ehsannas commented Jun 27, 2018

No description provided.

@ehsannas ehsannas added the linux-port label Jun 27, 2018

@ehsannas ehsannas self-assigned this Jun 27, 2018

@ehsannas ehsannas requested review from antiagainst and hekota Jun 27, 2018

@AppVeyorBot

This comment has been minimized.

@hekota

hekota approved these changes Jun 27, 2018

LGMT!

@@ -747,6 +767,7 @@ void DxcContext::Recompile(IDxcBlob *pSource, IDxcLibrary *pLibrary, IDxcCompile
ConcatArgs.size(), ConcatDefines.data(),
ConcatDefines.size(), pIncludeHandler, &pResult));
*ppCompileResult = pResult.Detach();
#endif // _WIN32

This comment has been minimized.

@hekota

hekota Jun 27, 2018

Member

Might be good to add an assert and set ppCompileResult to null in case someone calls this on Linux.

This comment has been minimized.

@ehsannas

ehsannas Jun 27, 2018

Collaborator

Good idea. Fixed.

@AppVeyorBot

This comment has been minimized.

@ehsannas ehsannas merged commit e8d5eb0 into Microsoft:master Jun 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@ehsannas ehsannas deleted the ehsannas:post_dxc branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment