Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix library checking while installing library on databricks cluster #1488

Merged
merged 5 commits into from
Apr 24, 2022

Conversation

serena-ruan
Copy link
Contributor

@serena-ruan serena-ruan commented Apr 22, 2022

Summary

Should check library installation status before submitting jobs for databricksTest

Tests

Ran Databricks test

Dependency changes

None.

AB#1759003

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #1488 (f904445) into master (3314d2d) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
- Coverage   84.47%   84.38%   -0.09%     
==========================================
  Files         295      295              
  Lines       14793    14793              
  Branches      702      702              
==========================================
- Hits        12496    12483      -13     
- Misses       2297     2310      +13     
Impacted Files Coverage Δ
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 69.11% <0.00%> (-13.24%) ⬇️
...ft/azure/synapse/ml/io/powerbi/PowerBIWriter.scala 80.00% <0.00%> (-8.58%) ⬇️
...se/ml/cognitive/MultivariateAnomalyDetection.scala 87.03% <0.00%> (-0.75%) ⬇️
.../execution/streaming/continuous/HTTPSourceV2.scala 92.44% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2c8f0...f904445. Read the comment docs.

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Just a nit on naming

@@ -229,6 +229,17 @@ object DatabricksUtilities extends HasHttpClient {
state == "RUNNING"
}

def isLibrariesAllInstalled(clusterId: String): Boolean = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isLibrariesAllInstalled -> areLibrariesInstalled

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan merged commit 918d92c into microsoft:master Apr 24, 2022
@serena-ruan serena-ruan deleted the serena/updateDatabricksTest branch April 24, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants