-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix library checking while installing library on databricks cluster #1488
fix: fix library checking while installing library on databricks cluster #1488
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
- Coverage 84.47% 84.38% -0.09%
==========================================
Files 295 295
Lines 14793 14793
Branches 702 702
==========================================
- Hits 12496 12483 -13
- Misses 2297 2310 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! Just a nit on naming
@@ -229,6 +229,17 @@ object DatabricksUtilities extends HasHttpClient { | |||
state == "RUNNING" | |||
} | |||
|
|||
def isLibrariesAllInstalled(clusterId: String): Boolean = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: isLibrariesAllInstalled -> areLibrariesInstalled
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Summary
Should check library installation status before submitting jobs for databricksTest
Tests
Ran Databricks test
Dependency changes
None.
AB#1759003