Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 3.5 Iteration Plan #30555

Closed
DanielRosenwasser opened this issue Mar 22, 2019 · 10 comments

Comments

Projects
None yet
9 participants
@DanielRosenwasser
Copy link
Member

commented Mar 22, 2019

This document outlines our focused tasks for TypeScript 3.5, as well as some of the discussion that explains how/why we prioritized certain work items. Nothing is set in stone, but we will strive to complete them in a reasonable timeframe.

Dates

Here's the release plan.

  1. May 10th: Create a release-3.5 branch, and update the version to 3.5.0-rc. master is locked from receiving new feature-work that is not 3.5-bound.
    1. Start a build of TypeScript for Visual Studio for our remote testing team.
  2. May 15th: Last day to adjust the release-3.5 branch with any feedback we receive.
    1. Kick off a final Visual Studio build if necessary.
    2. (2pm Pacific) Produce an insiders release for VS Code.
  3. Morning of May 16th: The release candidate goes out.
  4. May 24th: Merge master into release-3.5 one last time, finalize the version as 3.5.1. master is unlocked. Critical changes for 3.5 must be ported in.
    1. Start a build of TypeScript for Visual Studio for our remote testing team.
  5. May 29th: Last day to adjust the release-3.5 branch with any feedback we receive.
    1. Kick off a final Visual Studio build if necessary.
    2. (2pm Pacific) Produce an insiders release for VS Code which is identical to the final release.
  6. May 30th: Announcing TypeScript 3.5 🚀

Work Items

Expected Work Items

(🏃🏻‍ means work has already started)

Deferred Work Items


Planning Meeting Notes

Motivations

  • Goals and current 6-month roadmap
  • GitHub user feedback (👍s)
  • Feedback from customer interviews and social media.
  • Visual Studio and Visual Studio Code feedback and new functionality demands
  • Actionable PRs (need to make a call)
  • Bug backlog

General (compiler/infrastructure/reliability)

  • Negated types

    • Rationale: Core type system
    • Uses: control flow analysis on generic/"higher order" types
    • Problems: But you end up with lots of vacuous intersections that are "garbage" types.
    • Will likely lead to a tail of bugs, at least initially
    • Action item: need to prototype, see what sort of breakage we see with implementations of integration with control-flow analysis, and see what the perf impact is.
    • Work on this.
  • Arbitrary index signatures

    • Rationale: Core type system
    • Not a must for negated types
    • But like to get them done first.
    • Also need a unifying concept between them and mapped object types.
    • Resolution: Defer
  • Compiler API prototyping

    • Rationale: minification, 3rd party tools integration
    • In progress
  • Expecting --incremental build issues

    • Rationale: Stability, scaling, performance
  • Crawler work for testing TSServer

    • Rationale: Stability
    • Context:
      • IntelliCode team crawls public code to train on, but leverages TSServer.
      • Turns out that it was a great way to test TSServer and catch bugs!
      • We want to leverage it to get a good litmus that it's stable.
      • Give partner teams assurance that they can adopt nightly TypeScripts.
  • TSLint -> ESLint migration

    • Internal engineering
  • New engineer starting!

    • Ramping-up bugs
    • Website
      • Education and UX
  • globalThis-related work

    • Bug and standards involvement
    • Issues with block-scoped declarations interfacing with the global object.
  • --declaration with --allowJs

    • TypeScript beyond TypeScript
    • 🎉
  • --declaration with --isolatedModules

    • User demand
    • Aside: Ensure this all works with composite.
    • Resolution: investigate

Productivity

  • Smart Select API
    • #29071
    • VS Code ask, but generally applicable editor integration
  • Sorted/prioritized completions
    • #15024
    • Editor quality improvements
    • This and smart select have been around for long enough that they get priority.
  • Extract type refactoring
    • #23869
    • Shouldn't it just always work?
      • <T>(x: T): { value: T }
      • It has all the same problems as extract method!
        • Well you don't have to worry about control flow.
    • Could just do this for non-generic types for the minimal-viable product (MVP).
    • Resolution: try to get done for 3.5.
  • Call hierarchy breadcrumbs
    • microsoft/vscode#16110
    • VS Code ask, but generally applicable editor integration
    • Resolution: Probably will defer to next version.
@EisenbergEffect

This comment has been minimized.

Copy link

commented Mar 29, 2019

@DanielRosenwasser Thanks for being so transparent with the plans. It was way cool to read the 3.4 release announcement and then pop over here to see that you already have pretty developed plans for the next iteration.

Go TypeScript team!

@kirillgroshkov

This comment has been minimized.

Copy link

commented Mar 30, 2019

Amazing work guys!

@ExE-Boss

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

I’d like to see #30586 fixed.

Preferably in some way that isn’t just a band‑aid.

@xiaoxiangmoe

This comment has been minimized.

Copy link

commented Apr 6, 2019

What's TypeScript plugin API? Does this affect babel-plugin-transform-typescript users?

@mrmckeb

This comment has been minimized.

Copy link

commented Apr 7, 2019

Is it possible to be involved in testing for "Investigate TypeScript plugin APIs"?

I'd love to have typescript-plugin-css-modules available during build time. I'm currently in the process of reworking it a little, so please let me know.

@Yaojian

This comment has been minimized.

Copy link

commented May 21, 2019

I'd like to see #21592 fixed.

It force me to stuck with TypeScript 3.1.6 😢(the only version without this bug among TS 3.x)

@DanielRosenwasser

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

Hey all, just wanted to put out a couple of updates. A few of the items in this release were reprioritized, and as a result, what you see in the current feature roadmap is the closest to what you'll see in the release next week.

There are a couple of reasons why, but most of it was that TypeScript 3.4 was rockier than expected, and so was some breakage in TypeScript 3.5 itself. We ended up spending a lot of time servicing the last release or chasing down regressions.

It turns out that our testing infrastructure, while improved, needs investment. Our testing suite isn't up to date on real world code, and doesn't test things like editor scenarios (e.g. keystroke delays when a library like styled-components is present). We need to do our due diligence to invest in this testing infrastructure and run it more frequently on major changes. We also want to make it easier to contribute repositories to TypeScript's code suite.

Another thing we've been feeling is that we as a language need to have more time to let features "bake". We may be moving towards 3-month release cycles to address stability issues and feel confident in our design decisions. We'd like to experiment with this release cycle to ensure that users get stable well-designed features without compromising the rapid iteration we've been able to provide.

Much of this will also be coming in TypeScript 3.6. Keep posted for the upcoming iteration plan.

@SerayaEryn SerayaEryn referenced this issue May 28, 2019

Draft

Add support for class based plugins #1673

3 of 4 tasks complete
@DanielRosenwasser

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Just as one final heads up - due to personnel reasons, we'll be releasing tomorrow morning (the 29th) rather than Thursday the 30th. See you then!

@RyanCavanaugh

This comment has been minimized.

Copy link
Member

commented May 29, 2019

We did it!

@DanielRosenwasser DanielRosenwasser unpinned this issue May 29, 2019

@snurby7 snurby7 referenced this issue May 30, 2019

Merged

new updates #58

@glen-84

This comment has been minimized.

Copy link

commented Jun 4, 2019

Why hasn't 3.5.x been released on GitHub? It's tagged as the latest on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.