Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation of Js Files #5471

Merged
merged 105 commits into from
Nov 20, 2015
Merged

Compilation of Js Files #5471

merged 105 commits into from
Nov 20, 2015

Conversation

sheetalkamat
Copy link
Member

Changes same as #5345 with few modifications and against master
Here is the list of items this PR supports:

  • Allow javascript files to be compiled on command line or through references/imports
  • tsconfig.json can take javascript files as file names to be compiled
  • If filenames are not specified in tsconfig.json, javascript files in the folder and not part of compilation
  • compiler options now have a flag named "allowJs" which when true will pick up javascript files in the folder for compilation if tscconfig.json doesn't supply file name list
  • Moved reporting of usage of typescript syntax in javascript file from services to compiler
  • Reports error if output is overwriting any of the input files (TypeScript should error on duplicate output locations #4424)
  • Reports error if output is not unique location and multiple input files overwrite same output file (TypeScript should error on duplicate output locations #4424)
  • .ts, .tsx and .d.ts files take precedence over .js files when creating list of files for compilation
  • Project runner options cleanup
  • Project runner to accept tsconfig.json tests
  • Bundle js files into --out and copy into --outDir
  • Transpilation of javascript files
  • JavaScript files do not emit declaration files and it is error to specify --allowJs and --declaration together

@sheetalkamat
Add .js as supported extension
0a67ac3
@sheetalkamat
Emit the diagnostics for javascript file instead of doing semantic check
74a3f67
@sheetalkamat
Baseline updates
279018d
@sheetalkamat
Allow the js files to emit output
e9688dd
@sheetalkamat
Report error if output file is among the input files
fad0db2
@sheetalkamat
Add test cases for simple js file compilations
d3dfd2a
@sheetalkamat
Javascript files will emit declarations too so get declaration diagno…
1dc3414 
…stics
@sheetalkamat
Let harness to name file even when single unit data specified but the…
63de162 
…re is filename tag
@sheetalkamat
Test cases for different typescript syntax not supported errors durin…
57e17d2 
…g js files compilation
@sheetalkamat
Test for rest parameters(copied from language service tests)
7e30827
@sheetalkamat
Verify syntax error in js file are reported
2252354
@sheetalkamat
Let tsconfig to pick up js files
3107bbb
@sheetalkamat
Merge branch 'master' into tscJsFiles
885babc
@sheetalkamat
Cleanup of options of project runner
60f295f
@sheetalkamat
Project testcase to run tsconfig file
8da3bd2
@sheetalkamat
Add tests when same named .ts and .js file exist with tsconfig file s…
8aeff92 
…pecifying .ts file
@sheetalkamat
Merge branch 'master' into tscJsFiles
bc48c7c
@sheetalkamat
Verify and fix scenario when .js and .ts files with same name are pre…
9daf635 
…sent and tsconfig doesnt specify any filenames
@sheetalkamat
When same named .d.ts and .js files are present and tscconfig contain…
70d3de4 
…s .d.ts file
@sheetalkamat
When folder contains .d.ts as well as .js of same name and tsconfig d…
0f73c16 
…oesnt contain any name
@sheetalkamat
Tests when the .ts and .js files are mixed in compilation with tsccon…
dbb2772 
…fig file specifying them
@sheetalkamat
Tests when the .ts and .js files are mixed in compilation with tsccon…
14b6082 
…fig file doesnt specifying any names
@sheetalkamat
Do not emit javascript files
2860435
@sheetalkamat
Test case when one of the input file is output file name
68c65cd
@sheetalkamat
When tsconfig file doesnt contain file names, consume .js files of di…
fce9f32 
…rectory only if specified in the options
@sheetalkamat
Corrected scenario names in the test cases
e32c920
@sheetalkamat
Report error when emitting declarations if the reference is to .js file
60e15b2
@sheetalkamat
Merge branch 'master' into tscJsFiles
400b353
@sheetalkamat
Add option --jsExtensions to handle extensions to treat as javascript
c30104e 
- Command line now takes --jsExtension multiple times or comma separated list of extensions
- tsconfig accepts array of extension strings
@sheetalkamat
Merge branch 'master' into tscJsFilesxt
1df341b
@sheetalkamat
PR feedback
d2445b6
@sheetalkamat
Removed the TODO as created bug for it
1ed67f4
@sheetalkamat
Simplified logic of getting files if files werent suppplied in tsccon…
0b21540 
…fig.json

Since we dont support arbitary list of extensions to treat as .js,
it becomes easier to simplify code based on the assumptions
@sheetalkamat
When excluding same base name file from compilation, check for all su…
3bdad8a 
…pported javascript extensions instead of just .js
@sheetalkamat
Merge branch 'master' into jsFileCompilation
fc07763
@mhegazy mhegazy mentioned this pull request Nov 13, 2015
Merged
vladima
vladima reviewed Nov 16, 2015
View reviewed changes
src/compiler/checker.ts
@@ -12033,7 +12034,11 @@ namespace ts {
const symbol = getSymbolOfNode(node);
const localSymbol = node.localSymbol || symbol;

const firstDeclaration = getDeclarationOfKind(localSymbol, node.kind);
const firstDeclaration = forEach(symbol.declarations,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a comment

  • why we are not picking the first declaration if it originates in javascript file
  • why we are using symbol instead of localSymbol
    ?

@vladima
Copy link
Contributor

vladima commented Nov 17, 2015

looks good modulo few comments

@mhegazy mhegazy mentioned this pull request Nov 19, 2015
Closed
sheetalkamat added a commit that referenced this pull request Nov 20, 2015
@sheetalkamat
Merge pull request #5471 from Microsoft/jsFileCompilation
883b8d9 
Compilation of Js Files
@sheetalkamat sheetalkamat merged commit 883b8d9 into master Nov 20, 2015
@sheetalkamat sheetalkamat deleted the jsFileCompilation branch November 20, 2015 00:30
@sheetalkamat sheetalkamat mentioned this pull request Nov 20, 2015
Closed
@mhegazy mhegazy mentioned this pull request Nov 20, 2015
Closed
@frankwallis frankwallis mentioned this pull request Jan 31, 2016
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sheetalkamat @vladima @mihailik @mhegazy @msftclas