Fix for working with ServerlessFramework

[wscholar]

Authorization was coming in empty because it was checking caps vs lowercase.

[cleemullins]

@benbrown Can you take a look? How are non-standard cased parameters normally handled in JS

[cleemullins]

@benbrown @Stevenic The build is failing with this:

1) BotFrameworkAdapter
       should processActivity().:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/Microsoft/botbuilder-js/libraries/botbuilder/tests/botFrameworkAdapter.test.js)
  
  2) BotFrameworkAdapter
       should processActivity() sent as body.:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/Microsoft/botbuilder-js/libraries/botbuilder/tests/botFrameworkAdapter.test.js)
  
  3) BotFrameworkAdapter
       should return 500 error on bot logic exception during processActivity().:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/Microsoft/botbuilder-js/libraries/botbuilder/tests/botFrameworkAdapter.test.js)
  
  4) BotFrameworkAdapter
       should return bots 'invokeResponse'.:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/Microsoft/botbuilder-js/libraries/botbuilder/tests/botFrameworkAdapter.test.js)
  
  5) BotFrameworkAdapter
       should return 500 error if bot fails to return an 'invokeResponse'.:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/Microsoft/botbuilder-js/libraries/botbuilder/tests/botFrameworkAdapter.test.js)
  

[benbrown]

This is a reasonable approach to the problem, but I'm not sure why it broke the build. I'll check that out.

[wscholar]

Sounds good. I will check as well in a few hours if it hasn't been resolved

…

On Mon, Oct 1, 2018, 3:50 PM Ben Brown ***@***.***> wrote: This is a reasonable approach to the problem, but I'm not sure why it broke the build. I'll check that out. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APcwQg_23UA-0R9uHblEWNN0T-rd6bZZks5ugnIdgaJpZM4XCoGp> .

[benbrown]

@wscholar - the tests are failing because, in the absence of either header, your code leaves the variable null, whereas the tests expect at least an empty string.

Can you change your implementation to:
const authHeader: string = req.headers.authorization || req.headers.Authorization || '';

This should have the same impact.

[benbrown]

Make this:

const authHeader: string = req.headers.authorization || req.headers.Authorization || '';

[coveralls]

Pull Request Test Coverage Report for Build 1701

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.07%) to 70.461%

---

Totals
Change from base Build 1690:	0.07%
Covered Lines:	2206
Relevant Lines:	3003

---

💛 - Coveralls

[benbrown]

Thanks for the contribution, @wscholar