Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getEndpoint to ILuisService definition #549

Merged
merged 7 commits into from
Oct 18, 2018
Merged

Add getEndpoint to ILuisService definition #549

merged 7 commits into from
Oct 18, 2018

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Oct 17, 2018

fixes #546

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1864

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.265%
Totals Coverage Status
Change from base Build 1861: 0.0%
Covered Lines: 2317
Relevant Lines: 3057
💛 - Coveralls

benbrown
benbrown previously requested changes Oct 17, 2018
View reviewed changes
libraries/botframework-config/src/schema.ts Outdated Show resolved Hide resolved
@benbrown benbrown changed the title Tomlm/fix get endpoint Add getEndpoint to ILuisService definition Oct 17, 2018
cleemullins
cleemullins requested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no unit test for this.

Please add a test.

@tomlm tomlm dismissed benbrown’s stale review October 18, 2018 00:30

I accepted his suggested changes

@cleemullins cleemullins merged commit eec3c9d into master Oct 18, 2018
@cleemullins cleemullins deleted the tomlm/fixGetEndpoint branch October 18, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@benbrown benbrown benbrown left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does ILuisService need getEndpoint()?
4 participants
@tomlm @coveralls @benbrown @cleemullins