QnAMaker - Add getAnswers(), fix options in constructor, add metadata, create queryQnaMakerService() #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #637, #551, #675, microsoft/botframework-sdk#5143
Specific Changes
strictFilters
andmetadataBoost
inQnAMakerOptions
interfaceQnAMakerMetadata
interface forstrictFilters
andmetadataBoost
and parity with C#QnAMaker
class constructor now assignsoptions
argument passed in to_options
property and doesn't only keep hard-coded defaultsgenerateAnswers()
getAnswers()
to acceptQnAMakerOptions
and emit tracequeryQnaService()
which also acceptsQnAMakerOptions
callService()
now calls newqueryQnaService()
User-Agent
header to requests to QnAMaker servicegenerateAnswer()
that this PR will deprecateTo-Do: write more tests