Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert LUIS runtime library, pin LUIS and ms-rest dependencies #790

Merged
merged 1 commit into from
Feb 21, 2019
Merged

revert LUIS runtime library, pin LUIS and ms-rest dependencies #790

merged 1 commit into from
Feb 21, 2019

Conversation

stevengum
Copy link
Member

Fixes #788

Description

Revert LUIS dependency, pin ms-rest dependency to 2.5.0, and remove @azure-namespaced libraries.

@stevengum stevengum added the 4.3 February 14, 2019 Release label Feb 21, 2019
@johnataylor johnataylor merged commit 83cb63d into master Feb 21, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build #2004

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 87.441%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build #1997: -0.06%
Covered Lines: 3004
Relevant Lines: 3306
💛 - Coveralls

@stevengum stevengum deleted the stgum/luisRevert branch February 21, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

@sgellock sgellock Awaiting requested review from sgellock

@cleemullins cleemullins Awaiting requested review from cleemullins

@daveta daveta Awaiting requested review from daveta

Assignees
No one assigned
Labels
4.3 February 14, 2019 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @johnataylor