feat: adds fast-development-site for testing component libraries #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
suggested changes
Mar 3, 2018
| @@ -0,0 +1,2 @@ | |||
| import Site, { ISiteProps, ISiteCategoryProps } from "./site"; | |||
There was a problem hiding this comment.
to future proof, you can import and export the default, then do `export * from "./site";
| @@ -0,0 +1,36 @@ | |||
| import * as React from "react"; | |||
| import {ISiteCategoryItemProps} from "./"; | |||
There was a problem hiding this comment.
I think item props should be defined in the category-item
| } | ||
|
|
||
| private renderComponent(): JSX.Element[] { | ||
| return this.props.item.data.map((data: any, index: number) => { |
There was a problem hiding this comment.
you should check to make sure this.props has item and that item.data is an array
| import {ISiteCategoryItemProps} from "./"; | ||
|
|
||
| interface ICategoryItemProps { | ||
| item: ISiteCategoryItemProps; |
There was a problem hiding this comment.
should this component just expect ISiteCategoryItemProps?
| { | ||
| "extends": [ | ||
| "@microsoft/fast-tslint-rules", | ||
| "tslint-react" |
There was a problem hiding this comment.
fast-tslint-rules should already extend ts-lint react so I don't think you need this.
nicholasrice
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5