Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent coding style #4

Closed
cobookman opened this issue Nov 18, 2016 · 5 comments
Closed

Inconsistent coding style #4

cobookman opened this issue Nov 18, 2016 · 5 comments

Comments

@cobookman
Copy link

https://github.com/Microsoft/mssql-jdbc/blob/master/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerColumnEncryptionJavaKeyStoreProvider.java#L81

@ajlam
Copy link
Member

ajlam commented Nov 21, 2016

@cobookman Thanks for filing an issue about this! As we move forward with developing new features, etc., we will definitely keep coding style consistency in mind.

@cobookman
Copy link
Author

I wouldn't mind fixing all the style guide issues. And adding a linter to a github pre-commit hook. Just need a style guide to reference. Here's google's for example: https://google.github.io/styleguide/javaguide.html

Btw we are also prone to having style guide issues as well :D.
google/guava#1891

@sehrope
Copy link
Contributor

sehrope commented Dec 6, 2016

+1 for doing this now across the board.

Style changes are like taking off a band-aid. Best to get it over with all at once.

@adenfitz
Copy link

From https://blogs.msdn.microsoft.com/dotnet/2015/02/09/automatic-code-formatter-released-to-github/
"We strongly believe that having a consistent style greatly increases the readability and maintainability of a code base. The individual style decisions themselves are subjective, the key is the consistency of the decisions. As such the .NET team has a set of style guidelines for all C# code written by the team."

@v-nisidh
Copy link
Contributor

v-nisidh commented Feb 3, 2017

@cobookman : In current 6.1.3 release we fixed inconsistent coding style. You can find formatting rules in mssql-jdbc_formatter.xml

If you are satisfied then I will close this issue otherwise your comments are welcome.

lilgreenbird referenced this issue in lilgreenbird/mssql-jdbc Aug 13, 2020
Fix compilation errors after merging from master
lilgreenbird referenced this issue in lilgreenbird/mssql-jdbc Sep 25, 2020
David-Engel pushed a commit to David-Engel/mssql-jdbc that referenced this issue Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants