Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the jre8 version as default #59

Closed
gstojsic opened this issue Dec 3, 2016 · 1 comment
Closed

Set the jre8 version as default #59

gstojsic opened this issue Dec 3, 2016 · 1 comment
Assignees
@xiangyushawn
Labels
Under Review Used for pull requests under review

Comments

@gstojsic
Copy link
Contributor

gstojsic commented Dec 3, 2016

Currently issuing the command:
mvn clean install
for which most java developers expect that it should build something, issues an ugly build error. This is because a profile must be set in order for the build to succeed. Currently there are two profiles, one for jre8 and one for jre7. Consider making the jre8 default so that the above command builds the jre8 version by default.
@gstojsic gstojsic mentioned this issue Dec 3, 2016
Merged
@xiangyushawn xiangyushawn self-assigned this Dec 6, 2016
@xiangyushawn xiangyushawn added the Under Review Used for pull requests under review label Dec 6, 2016
@xiangyushawn
Copy link
Contributor

fixed by PR #60 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangyushawn xiangyushawn

Labels
Under Review Used for pull requests under review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiangyushawn @gstojsic