-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have cause of SQLServerException exception at any place where it possible #202
have cause of SQLServerException exception at any place where it possible #202
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #202 +/- ##
============================================
+ Coverage 33.45% 33.53% +0.08%
- Complexity 1488 1489 +1
============================================
Files 97 97
Lines 23390 23390
Branches 3840 3840
============================================
+ Hits 7824 7845 +21
+ Misses 14002 13980 -22
- Partials 1564 1565 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create some tests which expects exceptions and test if exceptions having appropriate cause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Please fix 2 Review Comments before merge.
} | ||
|
||
private void dropWaitForDelayProcedure(SQLServerConnection conn) throws SQLException { | ||
String sql = " IF EXISTS (select * from sysobjects where id = object_id(N'" + waitForDelaySPName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use new Utility for delete object. Utils.dropObjectIfExists(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is pretty old, before we have this Utils.dropObjectIfExists(...)
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to Utils.dropProcedureIfExists
after merging/updating with Dev branch
* | ||
* @return location of resource file | ||
*/ | ||
static String getCurrentClassPath() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to Util class as it is very much common to whole framework.
@v-suhame : Possibly we already might be having this functionality of getCurrentClassPath
somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have getCurrentClassPath()
in BulkCopyCSVTest as well. I moved them into Utils class.
for issue #139